Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: trunk/src/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm

Issue 252693007: Revert 266653 "[Mac] Allow fullscreen transitions while constrai..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm
===================================================================
--- trunk/src/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm (revision 266682)
+++ trunk/src/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm (working copy)
@@ -4,8 +4,10 @@
#include "chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h"
+#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/browser_window.h"
#import "chrome/browser/ui/cocoa/browser_window_controller.h"
@@ -155,3 +157,16 @@
TabStripModel::CLOSE_USER_GESTURE));
EXPECT_EQ(1, tab_strip->count());
}
+
+// Test that adding a sheet disables fullscreen.
+IN_PROC_BROWSER_TEST_F(ConstrainedWindowMacTest, Fullscreen) {
+ EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
+
+ // Dialog will delete it self when closed.
+ NiceMock<ConstrainedWindowDelegateMock> delegate;
+ ConstrainedWindowMac dialog(&delegate, tab1_, sheet_);
+
+ EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
+
+ dialog.CloseWebContentsModalDialog();
+}

Powered by Google App Engine
This is Rietveld 408576698