Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2526673003: gn: Remove redundant calls to Scheduler::Increment/DecrementWorkCount(). (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Remove redundant calls to Scheduler::Increment/DecrementWorkCount(). It is useless to call IncrementWorkCount() before ScheduleWork() and DecrementWorkCount() at the end of a callback scheduled by ScheduleWork(). Indeed, ScheduleWork() already calls IncrementWorkCount() and DecrementWorkCount() is already called after the execution of callbacks scheduled by ScheduleWork(). BUG= Committed: https://crrev.com/b0d8fb49cc75e8e6c6c7513754afe2ac54b5c8a7 Cr-Commit-Position: refs/heads/master@{#436369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/gn/command_gen.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
fdoray
PTAL
4 years ago (2016-11-23 14:11:24 UTC) #4
brettw
lgtm
4 years ago (2016-12-05 18:20:10 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 2515383005 Patch 1). Please resolve the dependency and ...
4 years ago (2016-12-05 18:23:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526673003/1
4 years ago (2016-12-05 18:44:38 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 18:59:00 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-05 19:02:24 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0d8fb49cc75e8e6c6c7513754afe2ac54b5c8a7
Cr-Commit-Position: refs/heads/master@{#436369}

Powered by Google App Engine
This is Rietveld 408576698