Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2515383005: gn: Remove Scheduler::pool(). (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, rginda+watch_chromium.org, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Remove Scheduler::pool(). InputFileManager used this accessor to post a BLOCK_SHUTDOWN task. This can be replaced by a call to ScheduleWork(). In both cases, Scheduler::Run() doesn't return before the task runs. BUG= Committed: https://crrev.com/5476ec6bf7ccbada1734a0cdec7d570bb042aa30 Cr-Commit-Position: refs/heads/master@{#436362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M tools/gn/input_file_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M tools/gn/scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
fdoray
PTAL
4 years ago (2016-11-23 14:05:35 UTC) #4
brettw
lgtm
4 years ago (2016-12-05 18:18:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515383005/1
4 years ago (2016-12-05 18:23:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 18:37:25 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-05 18:40:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5476ec6bf7ccbada1734a0cdec7d570bb042aa30
Cr-Commit-Position: refs/heads/master@{#436362}

Powered by Google App Engine
This is Rietveld 408576698