Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: tools/gn/command_gen.cc

Issue 2526673003: gn: Remove redundant calls to Scheduler::Increment/DecrementWorkCount(). (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_gen.cc
diff --git a/tools/gn/command_gen.cc b/tools/gn/command_gen.cc
index aac61e7fb7a147c8258e31c13de30b2929da3d0e..26fc729f7cfd97f8e482469f1e0572414585a215 100644
--- a/tools/gn/command_gen.cc
+++ b/tools/gn/command_gen.cc
@@ -63,8 +63,6 @@ void BackgroundDoWrite(TargetWriteInfo* write_info, const Target* target) {
write_info->rules[target->toolchain()].emplace_back(
target, std::move(rule));
}
-
- g_scheduler->DecrementWorkCount();
}
// Called on the main thread.
@@ -73,7 +71,6 @@ void ItemResolvedAndGeneratedCallback(TargetWriteInfo* write_info,
const Item* item = record->item();
const Target* target = item->AsTarget();
if (target) {
- g_scheduler->IncrementWorkCount();
g_scheduler->ScheduleWork(base::Bind(&BackgroundDoWrite,
write_info, target));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698