chrome/browser/extensions/api/web_navigation/web_navigation_api.h - Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc » ('j') | extensions/browser/extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

index 49d70c0e85c95399dff44422fd633013bab36fd5..d3aaf76b0204aef3db3c13ffb4cc76b76330c9d4 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

@@ -211,14 +211,14 @@ class WebNavigationEventRouter : public TabStripModelObserver,

// API function that returns the state of a given frame.

class WebNavigationGetFrameFunction : public ChromeSyncExtensionFunction {

virtual ~WebNavigationGetFrameFunction() {}

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

DECLARE_EXTENSION_FUNCTION("webNavigation.getFrame", WEBNAVIGATION_GETFRAME)

};

// API function that returns the states of all frames in a given tab.

class WebNavigationGetAllFramesFunction : public ChromeSyncExtensionFunction {

virtual ~WebNavigationGetAllFramesFunction() {}

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

DECLARE_EXTENSION_FUNCTION("webNavigation.getAllFrames",

WEBNAVIGATION_GETALLFRAMES)

};