Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

extensions/browser/extension_function.h

Index: extensions/browser/extension_function.h
diff --git a/extensions/browser/extension_function.h b/extensions/browser/extension_function.h
index ee58cba589164fc150d057196fab2b6fdcb0890d..ebc2fbe0214c4fd123bfc37b835d3fdf17f6d701 100644
--- a/extensions/browser/extension_function.h
+++ b/extensions/browser/extension_function.h
@@ -124,7 +124,7 @@ class ExtensionFunction
   // GetError() before returning from this function.
   // Note that once Run() returns, dispatcher() can be NULL, so be sure to
   // NULL-check.
-  virtual void Run();
+  void Run();

[Ken Rockot(use gerrit already), 2014/04/25 04:01:36]

The "Derived classes..." part of this documentation doesn't really apply to
Run() any more

[not at google - send to devlin, 2014/04/28 22:38:15]

oops missed this comment. i have the comment fix in a staged patch.

 
   // Gets whether quota should be applied to this individual function
   // invocation. This is different to GetQuotaLimitHeuristics which is only
@@ -502,9 +502,11 @@ class SyncExtensionFunction : public UIThreadExtensionFunction {
  public:
   SyncExtensionFunction();
 
-  virtual void Run() OVERRIDE;
+  virtual bool RunImpl() OVERRIDE;
 
  protected:
+  virtual bool RunSync() = 0;
+
   virtual ~SyncExtensionFunction();
 };
 
@@ -512,9 +514,11 @@ class SyncIOThreadExtensionFunction : public IOThreadExtensionFunction {
  public:
   SyncIOThreadExtensionFunction();
 
-  virtual void Run() OVERRIDE;
+  virtual bool RunImpl() OVERRIDE;
 
  protected:
+  virtual bool RunSync() = 0;
+
   virtual ~SyncIOThreadExtensionFunction();
 };