chrome/browser/extensions/api/web_navigation/web_navigation_api.cc - Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_api.h ('k') | chrome/browser/extensions/api/webcam_private/webcam_private_api.h » ('j') | extensions/browser/extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

index f41c1b1db030a88831f63772a87a9e5ae42e7254..a1902e9e76139b1625ab9b74c5b6aff1035f9ced 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

@@ -690,7 +690,7 @@ bool WebNavigationTabObserver::IsReferenceFragmentNavigation(

url.ReplaceComponents(replacements);

}

-bool WebNavigationGetFrameFunction::RunImpl() {

+bool WebNavigationGetFrameFunction::RunSync() {

scoped_ptr<GetFrame::Params> params(GetFrame::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

int tab_id = params->details.tab_id;

@@ -747,7 +747,7 @@ bool WebNavigationGetFrameFunction::RunImpl() {

return true;

}

-bool WebNavigationGetAllFramesFunction::RunImpl() {

+bool WebNavigationGetAllFramesFunction::RunSync() {

scoped_ptr<GetAllFrames::Params> params(GetAllFrames::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

int tab_id = params->details.tab_id;