Make URLRequestContext a MemoryDumpProvider (Abandoned)

net/url_request/url_request.cc

Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index eb4be23b475ae449ceb99622e739704d1c160304..7027f5248414bc7449dda8269df1844d3f73825f 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -15,9 +15,12 @@
 #include "base/profiler/scoped_tracker.h"
 #include "base/rand_util.h"
 #include "base/stl_util.h"
+#include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "base/trace_event/memory_allocator_dump.h"
+#include "base/trace_event/process_memory_dump.h"
 #include "base/values.h"
 #include "net/base/auth.h"
 #include "net/base/host_port_pair.h"
@@ -1214,6 +1217,16 @@ void URLRequest::GetConnectionAttempts(ConnectionAttempts* out) const {
     out->clear();
 }
 
+void URLRequest::DumpMemoryStats(
+    base::trace_event::MemoryAllocatorDump* dump) const {
+  if (!job_)
+    return;
+  base::trace_event::MemoryAllocatorDump* url_request_dump =
+      dump->process_memory_dump()->CreateAllocatorDump(base::StringPrintf(
+          "%s/url_request/%p", dump->absolute_name().c_str(), this));

[eroman, 2016/11/29 22:22:51]

Note, this presumes names can never contain a NUL character (here and anywhere
.c_str() is used). That may be a fine assumption to make.

[xunjieli, 2016/11/30 16:02:03]

Acknowledged.  
Looks like elsewhere .c_str() is used, so I guess we can make this assumption.
https://cs.chromium.org/search/?q=CreateAllocatorDump+base::StringPrintf&sq=p...
.
Thanks for pointing it out. I will keep this in mind.

+  job_->DumpMemoryStats(url_request_dump);
+}
+
 void URLRequest::set_status(URLRequestStatus status) {
   DCHECK(status_.is_io_pending() || status_.is_success() ||
          (!status.is_success() && !status.is_io_pending()));