Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2368)

Unified Diff: net/socket/tcp_client_socket.cc

Issue 2525743002: Make URLRequestContext a MemoryDumpProvider (Abandoned) (Closed)
Patch Set: rebased to 7f3d142161b15869f6bea58ac43c5f52ce5834ac Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/tcp_client_socket.cc
diff --git a/net/socket/tcp_client_socket.cc b/net/socket/tcp_client_socket.cc
index f8f612295295c40b54b2d19cbd4981508648b731..dfbe09dd3f1c5cf3ac407591859927ddf5f8b22e 100644
--- a/net/socket/tcp_client_socket.cc
+++ b/net/socket/tcp_client_socket.cc
@@ -337,6 +337,9 @@ int64_t TCPClientSocket::GetTotalReceivedBytes() const {
return total_received_bytes_;
}
+void TCPClientSocket::DumpMemoryStats(
+ base::trace_event::MemoryAllocatorDump* dump) const {}
eroman 2016/11/29 22:22:51 Presumably this remains to be implemented?
xunjieli 2016/11/30 16:02:03 Acknowledged. I've adopted the non-abstract approa
+
void TCPClientSocket::DidCompleteConnect(int result) {
DCHECK_EQ(next_connect_state_, CONNECT_STATE_CONNECT_COMPLETE);
DCHECK_NE(result, ERR_IO_PENDING);

Powered by Google App Engine
This is Rietveld 408576698