Make URLRequestContext a MemoryDumpProvider (Abandoned)

net/url_request/url_request.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/lazy_instance.h"
 #include "base/memory/singleton.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/rand_util.h"
 #include "base/stl_util.h"
+#include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "base/trace_event/memory_allocator_dump.h"
+#include "base/trace_event/process_memory_dump.h"
 #include "base/values.h"
 #include "net/base/auth.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/load_flags.h"
 #include "net/base/load_timing_info.h"
 #include "net/base/net_errors.h"
 #include "net/base/network_change_notifier.h"
 #include "net/base/network_delegate.h"
 #include "net/base/upload_data_stream.h"
 #include "net/http/http_response_headers.h"
@@ skipping 1176 matching lines @@
   net_log_.EndEvent(NetLogEventType::URL_REQUEST_DELEGATE);
 }
 
 void URLRequest::GetConnectionAttempts(ConnectionAttempts* out) const {
   if (job_)
     job_->GetConnectionAttempts(out);
   else
     out->clear();
 }
 
+void URLRequest::DumpMemoryStats(
+    base::trace_event::MemoryAllocatorDump* dump) const {
+  if (!job_)
+    return;
+  base::trace_event::MemoryAllocatorDump* url_request_dump =
+      dump->process_memory_dump()->CreateAllocatorDump(base::StringPrintf(
+          "%s/url_request/%p", dump->absolute_name().c_str(), this));

[eroman, 2016/11/29 22:22:51]

Note, this presumes names can never contain a NUL character (here and anywhere
.c_str() is used). That may be a fine assumption to make.

[xunjieli, 2016/11/30 16:02:03]

Acknowledged.  
Looks like elsewhere .c_str() is used, so I guess we can make this assumption.
https://cs.chromium.org/search/?q=CreateAllocatorDump+base::StringPrintf&sq=p...
.
Thanks for pointing it out. I will keep this in mind.

+  job_->DumpMemoryStats(url_request_dump);
+}
+
 void URLRequest::set_status(URLRequestStatus status) {
   DCHECK(status_.is_io_pending() || status_.is_success() ||
          (!status.is_success() && !status.is_io_pending()));
   status_ = status;
 }
 
 }  // namespace net