Make URLRequestContext a MemoryDumpProvider (Abandoned)

net/socket/stream_socket.h

Index: net/socket/stream_socket.h
diff --git a/net/socket/stream_socket.h b/net/socket/stream_socket.h
index b038d9b54db72cf727c6bf22e1eed3f65cd48a15..942e94bf15f3391355c79aa33c0c5aacdafc0177 100644
--- a/net/socket/stream_socket.h
+++ b/net/socket/stream_socket.h
@@ -13,6 +13,12 @@
 #include "net/socket/next_proto.h"
 #include "net/socket/socket.h"
 
+namespace base {
+namespace trace_event {
+class MemoryAllocatorDump;
+}
+}
+
 namespace net {
 
 class IPEndPoint;
@@ -110,6 +116,11 @@ class NET_EXPORT_PRIVATE StreamSocket : public Socket {
   // Disconnect() is called.
   virtual int64_t GetTotalReceivedBytes() const = 0;
 
+  // Called by the socket pool to dump memory allocation stats. |dump| is the
+  // MemoryAllocatorDump of the socket pool.
+  virtual void DumpMemoryStats(
+      base::trace_event::MemoryAllocatorDump* dump) const = 0;

[eroman, 2016/11/29 22:22:51]

For these various interface additions, I suggest making them non-abstract.

In other words, have a default implementation that does nothing.

That should reduce a lot of the locations that needed to be updated in this CL
(which I don't think are very useful to have to specify everywhere).

In general I agree that mandatory abstract methods are cleaner, but in this case
I think it is just a burden for iteratively adding things, and makes this
initial CL a bit harder to read than it needs to be :)

[xunjieli, 2016/11/29 22:42:04]

I had the non-abstract version in PS #1. However, there is a linker error, and I
am not quite sure what it means. I will look into it. 
 
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel...

FAILED: newlib_pnacl/remoting_client_plugin_newlib.pexe
newlib_pnacl/exe.unstripped/remoting_client_plugin_newlib.pexe 
python "../../build/toolchain/gcc_link_wrapper.py"
--strip="../../native_client/toolchain/mac_x86/pnacl_newlib/bin/pnacl-finalize"
--unstripped-file="newlib_pnacl/exe.unstripped/remoting_client_plugin_newlib.pexe"
--output="newlib_pnacl/remoting_client_plugin_newlib.pexe" --
../../native_client/toolchain/mac_x86/pnacl_newlib/bin/pnacl-clang++
-Wl,--fatal-warnings -Werror -Wl,-O1 -Wl,--gc-sections -o
"newlib_pnacl/exe.unstripped/remoting_client_plugin_newlib.pexe"
-Wl,--start-group @"newlib_pnacl/remoting_client_plugin_newlib.pexe.rsp" 
-Wl,--end-group   
newlib_pnacl/obj/remoting/protocol/libprotocol.a: error: undefined reference to
'net::StreamSocket::DumpMemoryStats(base::trace_event::MemoryAllocatorDump*)
const'

+
  protected:
   // The following class is only used to gather statistics about the history of
   // a socket.  It is only instantiated and used in basic sockets, such as