Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2525083002: Rename IFWL classes which do not have CFWL equivalents (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename IFWL classes which do not have CFWL equivalents This CL moves the IFWL classes that do not have CFWL class buddies to have the CFWL name. This CL leaves the tree in a weird state of having CFWL be two hierarchies, one of which is intertwined with the IFWL hierarchy. This should be commited just before the CL to move the rest of IFWL to CFWL. Committed: https://pdfium.googlesource.com/pdfium/+/0ce11eef157b791c661d7e82e1c5641605b9f03d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -4506 lines) Patch
M BUILD.gn View 4 chunks +20 lines, -20 lines 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + xfa/fwl/core/cfwl_caret.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + xfa/fwl/core/cfwl_caret.cpp View 5 chunks +14 lines, -14 lines 0 comments Download
A + xfa/fwl/core/cfwl_comboboxproxy.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + xfa/fwl/core/cfwl_comboboxproxy.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
A + xfa/fwl/core/cfwl_comboedit.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + xfa/fwl/core/cfwl_comboedit.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
A + xfa/fwl/core/cfwl_combolist.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + xfa/fwl/core/cfwl_combolist.cpp View 13 chunks +16 lines, -16 lines 0 comments Download
A + xfa/fwl/core/cfwl_datetimeedit.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + xfa/fwl/core/cfwl_datetimeedit.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fwl/core/cfwl_form.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + xfa/fwl/core/cfwl_form.cpp View 28 chunks +32 lines, -32 lines 0 comments Download
A + xfa/fwl/core/cfwl_formproxy.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + xfa/fwl/core/cfwl_formproxy.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
A + xfa/fwl/core/cfwl_monthcalendar.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + xfa/fwl/core/cfwl_monthcalendar.cpp View 45 chunks +51 lines, -51 lines 0 comments Download
M xfa/fwl/core/cfwl_notedriver.cpp View 7 chunks +6 lines, -6 lines 0 comments Download
A + xfa/fwl/core/cfwl_scrollbar.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + xfa/fwl/core/cfwl_scrollbar.cpp View 30 chunks +38 lines, -38 lines 0 comments Download
A + xfa/fwl/core/cfwl_spinbutton.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + xfa/fwl/core/cfwl_spinbutton.cpp View 16 chunks +23 lines, -23 lines 0 comments Download
M xfa/fwl/core/cfwl_widgetmgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_barcode.h View 1 chunk +1 line, -1 line 0 comments Download
D xfa/fwl/core/ifwl_caret.h View 1 chunk +0 lines, -57 lines 0 comments Download
D xfa/fwl/core/ifwl_caret.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.h View 3 chunks +10 lines, -10 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
D xfa/fwl/core/ifwl_comboboxproxy.h View 1 chunk +0 lines, -41 lines 0 comments Download
D xfa/fwl/core/ifwl_comboboxproxy.cpp View 1 chunk +0 lines, -119 lines 0 comments Download
D xfa/fwl/core/ifwl_comboedit.h View 1 chunk +0 lines, -35 lines 0 comments Download
D xfa/fwl/core/ifwl_comboedit.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
D xfa/fwl/core/ifwl_combolist.h View 1 chunk +0 lines, -43 lines 0 comments Download
D xfa/fwl/core/ifwl_combolist.cpp View 1 chunk +0 lines, -249 lines 0 comments Download
D xfa/fwl/core/ifwl_datetimeedit.h View 1 chunk +0 lines, -30 lines 0 comments Download
D xfa/fwl/core/ifwl_datetimeedit.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.h View 4 chunks +8 lines, -8 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_edit.h View 5 chunks +8 lines, -8 lines 0 comments Download
M xfa/fwl/core/ifwl_edit.cpp View 10 chunks +9 lines, -9 lines 0 comments Download
D xfa/fwl/core/ifwl_form.h View 1 chunk +0 lines, -101 lines 0 comments Download
D xfa/fwl/core/ifwl_form.cpp View 1 chunk +0 lines, -639 lines 0 comments Download
D xfa/fwl/core/ifwl_formproxy.h View 1 chunk +0 lines, -32 lines 0 comments Download
D xfa/fwl/core/ifwl_formproxy.cpp View 1 chunk +0 lines, -40 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
D xfa/fwl/core/ifwl_monthcalendar.h View 1 chunk +0 lines, -228 lines 0 comments Download
D xfa/fwl/core/ifwl_monthcalendar.cpp View 1 chunk +0 lines, -1111 lines 0 comments Download
D xfa/fwl/core/ifwl_scrollbar.h View 1 chunk +0 lines, -150 lines 0 comments Download
D xfa/fwl/core/ifwl_scrollbar.cpp View 1 chunk +0 lines, -563 lines 0 comments Download
D xfa/fwl/core/ifwl_spinbutton.h View 1 chunk +0 lines, -76 lines 0 comments Download
D xfa/fwl/core/ifwl_spinbutton.cpp View 1 chunk +0 lines, -381 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_carettp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_monthcalendartp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_scrollbartp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
dsinclair
PTAL. This should be committed just before https://codereview.chromium.org/2524173002/. This is a mechanical CL to move ...
4 years ago (2016-11-23 20:57:57 UTC) #4
Tom Sepez
RS LGTM
4 years ago (2016-11-23 21:00:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525083002/1
4 years ago (2016-11-24 00:02:46 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-24 00:03:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/0ce11eef157b791c661d7e82e1c5641605b9...

Powered by Google App Engine
This is Rietveld 408576698