Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2527683002: Remove DataProvider from CFWL_WidgetProperties (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove DataProvider from CFWL_WidgetProperties This CL removes the generic DataProvider code from CFWL_WidgetProperties and adds the specific providers to the two classes that require them. Committed: https://pdfium.googlesource.com/pdfium/+/7c47e1d3172ce6f625b93be50aac2ebf86a45d0c

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -86 lines) Patch
M xfa/fwl/core/cfwl_barcode.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_checkbox.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_combobox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_listbox.h View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_picturebox.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_picturebox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_pushbutton.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_pushbutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_widgetproperties.h View 2 chunks +0 lines, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_widgetproperties.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_barcode.h View 2 chunks +6 lines, -1 line 0 comments Download
M xfa/fwl/core/ifwl_barcode.cpp View 2 chunks +17 lines, -19 lines 0 comments Download
M xfa/fwl/core/ifwl_checkbox.h View 3 chunks +6 lines, -1 line 0 comments Download
M xfa/fwl/core/ifwl_checkbox.cpp View 4 chunks +2 lines, -14 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_picturebox.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_spinbutton.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 2 chunks +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
dsinclair
PTAL. Note, this depends on https://pdfium-review.googlesource.com/c/2050/ landing first.
4 years ago (2016-11-23 17:15:44 UTC) #2
Tom Sepez
lgtm
4 years ago (2016-11-23 18:40:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527683002/40001
4 years ago (2016-11-23 18:49:14 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-23 18:49:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/7c47e1d3172ce6f625b93be50aac2ebf86a4...

Powered by Google App Engine
This is Rietveld 408576698