Merge IFWL and CFWL classes.

Merge IFWL and CFWL classes.

This CL merges the IFWL hierarchy into the CFWL hierachy. All CFWL proxy methods
have been replaced by the IFWL implementations.

Committed: https://pdfium.googlesource.com/pdfium/+/2c489cc41023a40648dfde988d11b8ec2b66c7d0

[dsinclair, 2016-11-23 20:55:58]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 20:56:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-11-23 20:59:18]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-23 20:59:19]

PTAL.

This should be committed just after 
https://codereview.chromium.org/2525083002/.

The chunks of green additions are copies of the red removals. The only changes
are the sed commands to update the class names plus some stuff around the
constructors.

There are a few call site changes in the xfa_ff code to deal with the new world.

[commit-bot: I haz the power, 2016-11-23 20:59:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 20:59:51]

Dry run: Try jobs failed on following builders:
  android on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/...)

[dsinclair, 2016-11-23 21:23:52]

On 2016/11/23 20:59:51, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   android on master.tryserver.client.pdfium (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/...)

Red bots are due to patch failure. I'm guessing it's having problems because
this is based on the other large shuffling CL.

[Tom Sepez, 2016-11-23 22:07:17]

This is great.  For what I can check, it looks OK.  Can you build this under
chrome and hit up a few xfa pages manually to ensure we're still as functional
as before?

[dsinclair, 2016-11-23 22:23:28]

On 2016/11/23 22:07:17, Tom Sepez wrote:
> This is great.  For what I can check, it looks OK.  Can you build this under
> chrome and hit up a few xfa pages manually to ensure we're still as functional
> as before?

They seem good, tested a couple forms with text boxes, check boxes and drop
downs and they seemed to function correctly.

[Tom Sepez, 2016-11-23 22:37:22]

lgtm

[npm, 2016-11-23 22:48:24]

Looks good. There was no case where both the CFWL_X and the IFWL_X implemented a
method with the same name but CFWL_X's implementation was not just calling
IFWL_X, right?

https://codereview.chromium.org/2524173002/diff/1/xfa/fwl/core/cfwl_edit.h
File xfa/fwl/core/cfwl_edit.h (right):

https://codereview.chromium.org/2524173002/diff/1/xfa/fwl/core/cfwl_edit.h#ne...
xfa/fwl/core/cfwl_edit.h:80: virtual void SetText(const CFX_WideString& wsText);
Why is this virtual now but was not before?

[dsinclair, 2016-11-24 00:05:07]

https://codereview.chromium.org/2524173002/diff/1/xfa/fwl/core/cfwl_edit.h
File xfa/fwl/core/cfwl_edit.h (right):

https://codereview.chromium.org/2524173002/diff/1/xfa/fwl/core/cfwl_edit.h#ne...
xfa/fwl/core/cfwl_edit.h:80: virtual void SetText(const CFX_WideString& wsText);
On 2016/11/23 22:48:23, npm wrote:
> Why is this virtual now but was not before?

Because CFWL wasn't virtual but IFWL was.

[dsinclair, 2016-11-24 00:05:29]

On 2016/11/23 22:48:24, npm wrote:
> Looks good. There was no case where both the CFWL_X and the IFWL_X implemented
a
> method with the same name but CFWL_X's implementation was not just calling
> IFWL_X, right?
> 

Those were all merged over the last week of CLs.

[dsinclair, 2016-11-24 00:05:36]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-24 00:05:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 00:17:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479945936527530,
"parent_rev": "0ce11eef157b791c661d7e82e1c5641605b9f03d", "commit_rev":
"2c489cc41023a40648dfde988d11b8ec2b66c7d0"}

[commit-bot: I haz the power, 2016-11-24 00:17:24]

Description was changed from

==========
Merge IFWL and CFWL classes.

This CL merges the IFWL hierarchy into the CFWL hierachy. All CFWL proxy methods
have been replaced by the IFWL implementations.
==========

to

==========
Merge IFWL and CFWL classes.

This CL merges the IFWL hierarchy into the CFWL hierachy. All CFWL proxy methods
have been replaced by the IFWL implementations.

Committed:
https://pdfium.googlesource.com/pdfium/+/2c489cc41023a40648dfde988d11b8ec2b66...
==========

[commit-bot: I haz the power, 2016-11-24 00:17:25]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/2c489cc41023a40648dfde988d11b8ec2b66...

[Lei Zhang, 2017-08-16 00:59:19]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2017-08-16 00:59:22]

https://codereview.chromium.org/2524173002/diff/20001/xfa/fwl/core/ifwl_widge...
File xfa/fwl/core/ifwl_widgetmgrdelegate.h (right):

https://codereview.chromium.org/2524173002/diff/20001/xfa/fwl/core/ifwl_widge...
xfa/fwl/core/ifwl_widgetmgrdelegate.h:15: class CFWL_WidgetMgrDelegate {
What happened here? Did this accidentally get caught in the mass renaming? This
is clearly an Interface.