Re-land of Use parenthesis in descriptions for array/map/set lengths/sizes

Re-land of Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845
Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Committed: https://crrev.com/2c1fb7a8211f59e7378274cd6e12d64ca23488ca
Cr-Original-Commit-Position: refs/heads/master@{#41237}
Cr-Commit-Position: refs/heads/master@{#41442}

[luoe, 2016-11-22 23:37:31]

Description was changed from

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

BUG=405845
==========

to

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

BUG=405845
==========

[luoe, 2016-11-22 23:48:05]

Description was changed from

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

BUG=405845
==========

to

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845
==========

[luoe, 2016-11-22 23:50:00]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org, kozyatinskiy@chromium.org

[luoe, 2016-11-22 23:50:01]

This change is also described in section B3 on array hints in the doc linked in
the crbug.  Please take a look.

[kozy, 2016-11-23 01:04:39]

Could you add test for set and map?

https://codereview.chromium.org/2521853003/diff/1/src/inspector/injected-scri...
File src/inspector/injected-script-source.js (right):

https://codereview.chromium.org/2521853003/diff/1/src/inspector/injected-scri...
src/inspector/injected-script-source.js:632: className += "(" + obj.length +
")";
className += "(" + obj.length + ")"; -> return className + "(" + obj.length +
")";

https://codereview.chromium.org/2521853003/diff/1/src/inspector/injected-scri...
src/inspector/injected-script-source.js:638: className += "(" + obj.size + ")";
ditto

[luoe, 2016-11-23 18:36:25]

Test added "length-or-size-description.js"

https://codereview.chromium.org/2521853003/diff/1/src/inspector/injected-scri...
File src/inspector/injected-script-source.js (right):

https://codereview.chromium.org/2521853003/diff/1/src/inspector/injected-scri...
src/inspector/injected-script-source.js:632: className += "(" + obj.length +
")";
On 2016/11/23 01:04:39, kozyatinskiy wrote:
> className += "(" + obj.length + ")"; -> return className + "(" + obj.length +
> ")";

Done.

https://codereview.chromium.org/2521853003/diff/1/src/inspector/injected-scri...
src/inspector/injected-script-source.js:638: className += "(" + obj.size + ")";
On 2016/11/23 01:04:39, kozyatinskiy wrote:
> ditto

Done.

[kozy, 2016-11-23 18:49:10]

lgtm

https://codereview.chromium.org/2521853003/diff/20001/test/inspector/runtime/...
File test/inspector/runtime/length-or-size-description.js (right):

https://codereview.chromium.org/2521853003/diff/20001/test/inspector/runtime/...
test/inspector/runtime/length-or-size-description.js:7: testExpression("new
Set()")
V8 run microtasks in the scheduled first - run first order we can try to replace
this code with following.
Promise.all([
    testExpression("new Set()"),
    testExpression("new Set([1,2])")),
    testExpression("new Map()")),
    testExpression("new Map([[1,2],[3,4]])")),
    testExpression("new Array()")),
    testExpression("new Array(2)")),
    testExpression("new Uint8Array()")),
    testExpression("new Uint8Array(2)"))
]).then(() => InspectorTest.completeTest());

[luoe, 2016-11-23 19:23:32]

https://codereview.chromium.org/2521853003/diff/20001/test/inspector/runtime/...
File test/inspector/runtime/length-or-size-description.js (right):

https://codereview.chromium.org/2521853003/diff/20001/test/inspector/runtime/...
test/inspector/runtime/length-or-size-description.js:7: testExpression("new
Set()")
On 2016/11/23 18:49:10, kozyatinskiy wrote:
> V8 run microtasks in the scheduled first - run first order we can try to
replace
> this code with following.
> Promise.all([
>     testExpression("new Set()"),
>     testExpression("new Set([1,2])")),
>     testExpression("new Map()")),
>     testExpression("new Map([[1,2],[3,4]])")),
>     testExpression("new Array()")),
>     testExpression("new Array(2)")),
>     testExpression("new Uint8Array()")),
>     testExpression("new Uint8Array(2)"))
> ]).then(() => InspectorTest.completeTest());

Done.

[luoe, 2016-11-23 19:23:36]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 19:23:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 19:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 19:49:34]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-11-23 19:50:28]

Description was changed from

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845
==========

to

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[luoe, 2016-11-23 19:50:40]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 19:50:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 19:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 19:51:34]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)

[luoe, 2016-11-24 01:08:15]

Description was changed from

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845
==========

[luoe, 2016-11-24 01:08:39]

The CQ bit was checked by luoe@chromium.org

[luoe, 2016-11-24 01:08:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2521853003/#ps40001
(title: "ac")

[commit-bot: I haz the power, 2016-11-24 01:08:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 01:11:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479949719926770,
"parent_rev": "cfa83e4513df1a0c05bdafc9669934550c22e909", "commit_rev":
"2de5573157c74ce15065bbcd81b8980af032c6e4"}

[commit-bot: I haz the power, 2016-11-24 01:11:08]

Description was changed from

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845
==========

to

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845
==========

[commit-bot: I haz the power, 2016-11-24 01:11:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-24 01:11:29]

Description was changed from

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845
==========

to

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845

Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Cr-Commit-Position: refs/heads/master@{#41237}
==========

[commit-bot: I haz the power, 2016-11-24 01:11:30]

Patchset 3 (id:??) landed as
https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Cr-Commit-Position: refs/heads/master@{#41237}

[Michael Achenbach, 2016-11-24 07:21:47]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2530803002/ by machenbach@chromium.org.

The reason for reverting is: Breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

https://github.com/v8/v8/wiki/Blink-layout-tests.

[kozy, 2016-12-01 22:22:52]

Description was changed from

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845

Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Cr-Commit-Position: refs/heads/master@{#41237}
==========

to

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845

Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Cr-Commit-Position: refs/heads/master@{#41237}
==========

[luoe, 2016-12-01 22:33:59]

Description was changed from

==========
Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845

Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Cr-Commit-Position: refs/heads/master@{#41237}
==========

to

==========
Re-land of Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845

Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Cr-Commit-Position: refs/heads/master@{#41237}
==========

[luoe, 2016-12-01 23:46:19]

Description was changed from

==========
Re-land of Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845

Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Cr-Commit-Position: refs/heads/master@{#41237}
==========

to

==========
Re-land of Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Cr-Commit-Position: refs/heads/master@{#41237}
==========

[luoe, 2016-12-01 23:46:29]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 23:46:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 23:47:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 23:47:43]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)

[luoe, 2016-12-02 01:24:14]

Description was changed from

==========
Re-land of Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Cr-Commit-Position: refs/heads/master@{#41237}
==========

to

==========
Re-land of Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845

Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Cr-Commit-Position: refs/heads/master@{#41237}
==========

[luoe, 2016-12-02 01:24:24]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-12-02 01:24:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 01:26:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480641864136990,
"parent_rev": "a4bea5f4bf6561f62583abda52fc9496a575774a", "commit_rev":
"260db19db134d0c447049de08200a15cd14818db"}

[luoe, 2016-12-02 01:26:26]

On 2016/11/24 07:21:47, Michael Achenbach wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2530803002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: Breaks layout tests:
>
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...
> 
> https://github.com/v8/v8/wiki/Blink-layout-tests.

Thanks for the revert.  Sorry for breaking the tests, I've updated the
TestExpectations on the Blink layout tests side
https://codereview.chromium.org/2550513002/

After that landed, I ran this CL on linux_trusty_blink_rel, and it passed, so it
should be clear for re-landing.

[commit-bot: I haz the power, 2016-12-02 01:26:31]

Description was changed from

==========
Re-land of Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845

Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Cr-Commit-Position: refs/heads/master@{#41237}
==========

to

==========
Re-land of Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845

Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Cr-Commit-Position: refs/heads/master@{#41237}
==========

[commit-bot: I haz the power, 2016-12-02 01:26:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-02 01:26:51]

Description was changed from

==========
Re-land of Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845

Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Cr-Commit-Position: refs/heads/master@{#41237}
==========

to

==========
Re-land of Use parenthesis in descriptions for array/map/set lengths/sizes

Descriptions for (typed)arrays will use parenthesis instead of square brackets
"Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions
of maps and sets.

Related CL for DevTools: https://codereview.chromium.org/2524913002/

BUG=405845

Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d
Committed: https://crrev.com/2c1fb7a8211f59e7378274cd6e12d64ca23488ca
Cr-Original-Commit-Position: refs/heads/master@{#41237}
Cr-Commit-Position: refs/heads/master@{#41442}
==========

[commit-bot: I haz the power, 2016-12-02 01:26:52]

Patchset 3 (id:??) landed as
https://crrev.com/2c1fb7a8211f59e7378274cd6e12d64ca23488ca
Cr-Commit-Position: refs/heads/master@{#41442}