Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2716683003: DO NOT COMMIT DevTools: reintroduce fullViewportUpdate (Closed)

Created:
3 years, 10 months ago by luoe
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: reintroduce fullViewportUpdate BUG=679815

Patch Set 1 #

Patch Set 2 : hopefully clearer api #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewport.js View 1 3 chunks +9 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (3 generated)
luoe
This patch is to reintroduce the fullViewportUpdate that I removed in another patch that landed ...
3 years, 10 months ago (2017-02-23 23:27:10 UTC) #2
luoe
3 years, 10 months ago (2017-02-24 01:49:40 UTC) #3
Hopefully fullViewportUpdate() is a clearer name that indicates this function
will call willHide for all current messages in viewport and wasShown for all
messages in the viewport, even if they were there before.

Powered by Google App Engine
This is Rietveld 408576698