appengine/findit/handlers/crash/crash_handler.py - Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/handlers/crash/crash_handler.py

Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument. (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/handlers/crash/crash_handler.py

diff --git a/appengine/findit/handlers/crash/crash_handler.py b/appengine/findit/handlers/crash/crash_handler.py

index 70d14fce681645f9cb09ee1ddfa60724d58112dd..939a8b730dff08301eb5c364f8fefa8c7f30dae7 100644

--- a/appengine/findit/handlers/crash/crash_handler.py

+++ b/appengine/findit/handlers/crash/crash_handler.py

@@ -129,7 +129,7 @@ def ScheduleNewAnalysis(crash_data):

True if we started a new pipeline; False otherwise.

"""

client_id = crash_data['client_id']

- repository = GitilesRepository(http_client=HttpClientAppengine())

+ repository = GitilesRepository(HttpClientAppengine())

# N.B., must call FinditForClientID indirectly, for mock testing.

findit_client = crash_pipeline.FinditForClientID(client_id, repository)