appengine/findit/handlers/help_triage.py - Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/handlers/help_triage.py

Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument. (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/handlers/help_triage.py

diff --git a/appengine/findit/handlers/help_triage.py b/appengine/findit/handlers/help_triage.py

index a950ea9c592c129906e4a17c5e457af0870fa55e..03efb742d448cdf751592561a86b0662e971cd40 100644

--- a/appengine/findit/handlers/help_triage.py

+++ b/appengine/findit/handlers/help_triage.py

@@ -39,7 +39,7 @@ def _AllFailedStepsPassed(passed_steps, current_failed_steps):

def GetPossibleRevertInfoFromRevision(revision):

"""Parse message to get information of reverting and reverted cls."""

git_repo = GitilesRepository(

- 'https://chromium.googlesource.com/chromium/src.git', HttpClient())

+ HttpClient(), 'https://chromium.googlesource.com/chromium/src.git')

change_log = git_repo.GetChangeLog(revision)

if not change_log: # pragma: no cover

return {}