Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1515)

Unified Diff: appengine/findit/crash/test/findit_for_chromecrash_test.py

Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/findit_for_chromecrash_test.py
diff --git a/appengine/findit/crash/test/findit_for_chromecrash_test.py b/appengine/findit/crash/test/findit_for_chromecrash_test.py
index e2edc1a62bbd10148c4103c10f8c4101f5912282..ab1c64121fbe43e7c279cd7cc8cbf59ab596109a 100644
--- a/appengine/findit/crash/test/findit_for_chromecrash_test.py
+++ b/appengine/findit/crash/test/findit_for_chromecrash_test.py
@@ -69,7 +69,7 @@ def _FinditForFracas():
class FinditForChromeCrashTest(CrashTestCase):
chrome_dep_fetcher = chrome_dependency_fetcher.ChromeDependencyFetcher(
- gitiles_repository.GitilesRepository(http_client=HttpClientAppengine()))
+ gitiles_repository.GitilesRepository(HttpClientAppengine()))
# TODO(wrengr): what was the purpose of this test? As written it's
# just testing that mocking works. I'm guessing it was to check that
@@ -89,7 +89,7 @@ class FinditForChromeCrashTest(CrashTestCase):
analysis.client_id = CrashClient.FRACAS
findit_client = _FinditForChromeCrash(
- gitiles_repository.GitilesRepository(http_client=HttpClientAppengine()))
+ gitiles_repository.GitilesRepository(HttpClientAppengine()))
self.assertIsNone(findit_client.FindCulprit(analysis))
« no previous file with comments | « appengine/findit/crash/test/changelist_classifier_test.py ('k') | appengine/findit/handlers/crash/crash_handler.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698