[Culprit-Finder] Refactor GitilesRepostory to make http_client required argument.

appengine/findit/crash/test/findit_for_chromecrash_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from common import chrome_dependency_fetcher
 from common.dependency import DependencyRoll
 from common.http_client_appengine import HttpClientAppengine
 from crash import chromecrash_parser
 from crash import detect_regression_range
 from crash import findit_for_chromecrash
@@ skipping 51 matching lines @@
     return {}
 
 def _FinditForFracas():
   """A helper to pass in the standard pipeline class."""
   return FinditForFracas(MOCK_REPOSITORY)
 
 
 class FinditForChromeCrashTest(CrashTestCase):
 
   chrome_dep_fetcher = chrome_dependency_fetcher.ChromeDependencyFetcher(
-      gitiles_repository.GitilesRepository(http_client=HttpClientAppengine()))
+      gitiles_repository.GitilesRepository(HttpClientAppengine()))
 
   # TODO(wrengr): what was the purpose of this test? As written it's
   # just testing that mocking works. I'm guessing it was to check that
   # we fail when the analysis is for the wrong client_id; but if so,
   # then we shouldn't need to mock FindCulprit...
   def testFindCulprit(self):
     self.mock(FinditForChromeCrash, 'FindCulprit', lambda self, *_: None)
 
     # TODO(wrengr): would be less fragile to call
     # FinditForFracas.CreateAnalysis instead; though if I'm right about
     # the original purpose of this test, then this is one of the few
     # places where calling FracasCrashAnalysis directly would actually
     # make sense.
     analysis = FracasCrashAnalysis.Create({'signature': 'sig'})
     # TODO(wrengr): shouldn't FracasCrashAnalysis.Create already have set
     # the client_id?
     analysis.client_id = CrashClient.FRACAS
 
     findit_client = _FinditForChromeCrash(
-        gitiles_repository.GitilesRepository(http_client=HttpClientAppengine()))
+        gitiles_repository.GitilesRepository(HttpClientAppengine()))
     self.assertIsNone(findit_client.FindCulprit(analysis))
 
 
 class FinditForFracasTest(CrashTestCase):
 
   def testPlatformRename(self):
     self.assertEqual(_FinditForFracas().RenamePlatform('linux'), 'unix')
 
   def testCheckPolicyUnsupportedPlatform(self):
     self.assertIsNone(_FinditForFracas().CheckPolicy(DummyCrashData(
@@ skipping 149 matching lines @@
     expected_tag = {
           'found_suspects': False,
           'found_project': False,
           'found_components': False,
           'has_regression_range': False,
           'solution': 'core_algorithm',
     }
 
     self.assertDictEqual(expected_results, results)
     self.assertDictEqual(expected_tag, tag)