Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: appengine/findit/crash/test/stacktrace_test_suite.py

Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/stacktrace_test_suite.py
diff --git a/appengine/findit/crash/test/stacktrace_test_suite.py b/appengine/findit/crash/test/stacktrace_test_suite.py
index 16fc3455afba19ca76073ed38435b0f78d7237d4..e617f9a5369560a30a01d5288b08ba863581767c 100644
--- a/appengine/findit/crash/test/stacktrace_test_suite.py
+++ b/appengine/findit/crash/test/stacktrace_test_suite.py
@@ -4,8 +4,10 @@
from testing_utils import testing
+from crash.test.crash_testcase import CrashTestCase
-class StacktraceTestSuite(testing.AppengineTestCase): #pragma: no cover.
+
+class StacktraceTestSuite(CrashTestCase): #pragma: no cover.
wrengr 2016/11/22 19:11:53 Is this change related to the rest of the CL?
Sharu Jiang 2016/11/22 20:15:38 Yes, since the GetMockHttpClient is in TestCase in
def _VerifyTwoStackFramesEqual(self, frame1, frame2):
self.assertEqual(str(frame1), str(frame2))

Powered by Google App Engine
This is Rietveld 408576698