appengine/findit/crash/test/stacktrace_test_suite.py - Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/crash/test/stacktrace_test_suite.py

Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« appengine/findit/crash/test/changelist_classifier_test.py ('K') | « appengine/findit/crash/test/findit_for_chromecrash_test.py ('k') | appengine/findit/handlers/crash/crash_handler.py » ('j') | appengine/findit/lib/gitiles/gitiles_repository.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from testing_utils import testing	5 from testing_utils import testing

6	6

	7 from crash.test.crash_testcase import CrashTestCase

7	8

8 class StacktraceTestSuite(testing.AppengineTestCase): #pragma: no cover.	9

	10 class StacktraceTestSuite(CrashTestCase): #pragma: no cover.
	wrengr 2016/11/22 19:11:53 Is this change related to the rest of the CL? Is this change related to the rest of the CL? Sharu Jiang 2016/11/22 20:15:38 Yes, since the GetMockHttpClient is in TestCase in Show quoted text On 2016/11/22 19:11:53, wrengr wrote: > Is this change related to the rest of the CL? Yes, since the GetMockHttpClient is in TestCase in the dependency cl https://codereview.chromium.org/2521773004#ps20001 But it's better that this change goes to the dependency cl.
9	11

10 def _VerifyTwoStackFramesEqual(self, frame1, frame2):	12 def _VerifyTwoStackFramesEqual(self, frame1, frame2):

11 self.assertEqual(str(frame1), str(frame2))	13 self.assertEqual(str(frame1), str(frame2))

12 self.assertEqual(frame1.dep_path, frame2.dep_path)	14 self.assertEqual(frame1.dep_path, frame2.dep_path)

13	15

14 def _VerifyTwoCallStacksEqual(self, stack1, stack2):	16 def _VerifyTwoCallStacksEqual(self, stack1, stack2):

15 self.assertEqual(len(stack1), len(stack2))	17 self.assertEqual(len(stack1), len(stack2))

16 self.assertEqual(stack1.priority, stack2.priority)	18 self.assertEqual(stack1.priority, stack2.priority)

17 self.assertEqual(stack1.format_type, stack2.format_type)	19 self.assertEqual(stack1.format_type, stack2.format_type)

18 self.assertEqual(stack1.language_type, stack2.language_type)	20 self.assertEqual(stack1.language_type, stack2.language_type)

19 map(self._VerifyTwoStackFramesEqual, stack1, stack2)	21 map(self._VerifyTwoStackFramesEqual, stack1, stack2)

20	22

21 def _VerifyTwoStacktracesEqual(self, stacktrace1, stacktrace2):	23 def _VerifyTwoStacktracesEqual(self, stacktrace1, stacktrace2):

22 self.assertEqual(len(stacktrace1), len(stacktrace2))	24 self.assertEqual(len(stacktrace1), len(stacktrace2))

23 map(self._VerifyTwoCallStacksEqual, stacktrace1, stacktrace2)	25 map(self._VerifyTwoCallStacksEqual, stacktrace1, stacktrace2)

OLD	NEW