Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2910)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: appengine/findit/lib/gitiles/gitiles_repository.py

Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« appengine/findit/crash/test/stacktrace_test_suite.py ('K') | « appengine/findit/handlers/help_triage.py ('k') | appengine/findit/lib/gitiles/test/gitiles_repository_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/lib/gitiles/gitiles_repository.py
diff --git a/appengine/findit/lib/gitiles/gitiles_repository.py b/appengine/findit/lib/gitiles/gitiles_repository.py
index a07b19a7bbe90bab97dcd42d25b1aabc5ae2e2c0..74a74cb632629e8b1c48417b9552c9acc43016f8 100644
--- a/appengine/findit/lib/gitiles/gitiles_repository.py
+++ b/appengine/findit/lib/gitiles/gitiles_repository.py
@@ -34,7 +34,7 @@ class GitilesRepository(GitRepository):
"""Use Gitiles to access a repository on https://chromium.googlesource.com."""
# TODO(crbug.com/659449): Refactor the http_client to be required argument.
wrengr 2016/11/22 19:11:53 Can get rid of this todo
Sharu Jiang 2016/11/22 20:15:38 Done.
- def __init__(self, repo_url=None, http_client=None):
+ def __init__(self, http_client, repo_url=None):
super(GitilesRepository, self).__init__()
if repo_url and repo_url.endswith('/'):
self._repo_url = repo_url[:-1]
« appengine/findit/crash/test/stacktrace_test_suite.py ('K') | « appengine/findit/handlers/help_triage.py ('k') | appengine/findit/lib/gitiles/test/gitiles_repository_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698