[ObjC ARC] Converts ios/chrome/browser/find_in_page:find_in_page to ARC.Automatically generated A…

[ObjC ARC] Converts ios/chrome/browser/find_in_page:find_in_page to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Committed: https://crrev.com/4c6f265721e5a032d0fe8f138274264db05b7fa1
Cr-Commit-Position: refs/heads/master@{#434517}

[stkhapugin, 2016-11-24 15:53:56]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 15:54:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 16:22:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 16:22:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stkhapugin, 2016-11-25 09:54:04]

stkhapugin@chromium.org changed reviewers:
+ noyau@chromium.org

[stkhapugin, 2016-11-25 09:54:05]

PTAL. Passes downstream tests.

[noyau (Ping after 24h), 2016-11-25 10:27:46]

https://codereview.chromium.org/2524383002/diff/1/ios/chrome/browser/find_in_...
File ios/chrome/browser/find_in_page/find_in_page_model.h (right):

https://codereview.chromium.org/2524383002/diff/1/ios/chrome/browser/find_in_...
ios/chrome/browser/find_in_page/find_in_page_model.h:18: @property(weak,
nonatomic, readonly) NSString* text;
Weak? The implementation is doing copy... For a read only property I'd rather
see nothing rather than something wrong.

https://codereview.chromium.org/2524383002/diff/1/ios/chrome/browser/find_in_...
File ios/chrome/browser/find_in_page/js_findinpage_manager.h (right):

https://codereview.chromium.org/2524383002/diff/1/ios/chrome/browser/find_in_...
ios/chrome/browser/find_in_page/js_findinpage_manager.h:35: @property(weak,
nonatomic, readonly) FindInPageModel* findInPageModel;
Same here.

https://codereview.chromium.org/2524383002/diff/1/ios/chrome/browser/find_in_...
File ios/chrome/browser/find_in_page/js_findinpage_manager.mm (left):

https://codereview.chromium.org/2524383002/diff/1/ios/chrome/browser/find_in_...
ios/chrome/browser/find_in_page/js_findinpage_manager.mm:140:
base::WeakNSObject<JsFindinpageManager> strongSelf([weakSelf retain]);
Hu? A supposed "strongSelf" stored in a Weak? This makes no sense.

[stkhapugin, 2016-11-25 11:23:04]

Thanks for great comments, PTAL

https://codereview.chromium.org/2524383002/diff/1/ios/chrome/browser/find_in_...
File ios/chrome/browser/find_in_page/find_in_page_model.h (right):

https://codereview.chromium.org/2524383002/diff/1/ios/chrome/browser/find_in_...
ios/chrome/browser/find_in_page/find_in_page_model.h:18: @property(weak,
nonatomic, readonly) NSString* text;
On 2016/11/25 10:27:46, noyau wrote:
> Weak? The implementation is doing copy... For a read only property I'd rather
> see nothing rather than something wrong.

Done.

https://codereview.chromium.org/2524383002/diff/1/ios/chrome/browser/find_in_...
File ios/chrome/browser/find_in_page/js_findinpage_manager.h (right):

https://codereview.chromium.org/2524383002/diff/1/ios/chrome/browser/find_in_...
ios/chrome/browser/find_in_page/js_findinpage_manager.h:35: @property(weak,
nonatomic, readonly) FindInPageModel* findInPageModel;
On 2016/11/25 10:27:46, noyau wrote:
> Same here.

Done.

https://codereview.chromium.org/2524383002/diff/1/ios/chrome/browser/find_in_...
File ios/chrome/browser/find_in_page/js_findinpage_manager.mm (left):

https://codereview.chromium.org/2524383002/diff/1/ios/chrome/browser/find_in_...
ios/chrome/browser/find_in_page/js_findinpage_manager.mm:140:
base::WeakNSObject<JsFindinpageManager> strongSelf([weakSelf retain]);
On 2016/11/25 10:27:46, noyau wrote:
> Hu? A supposed "strongSelf" stored in a Weak? This makes no sense.

This is the coolest catch!

[noyau (Ping after 24h), 2016-11-25 12:56:26]

https://codereview.chromium.org/2524383002/diff/20001/ios/chrome/browser/find...
File ios/chrome/browser/find_in_page/find_in_page_controller.mm (right):

https://codereview.chromium.org/2524383002/diff/20001/ios/chrome/browser/find...
ios/chrome/browser/find_in_page/find_in_page_controller.mm:45: @property(weak,
nonatomic, readonly)
This one also, readonly and weak makes no sense.

Seriously, this is not behaving like a property, why is it not just a method?

[stkhapugin, 2016-11-25 14:19:39]

PTAL

https://codereview.chromium.org/2524383002/diff/20001/ios/chrome/browser/find...
File ios/chrome/browser/find_in_page/find_in_page_controller.mm (right):

https://codereview.chromium.org/2524383002/diff/20001/ios/chrome/browser/find...
ios/chrome/browser/find_in_page/find_in_page_controller.mm:45: @property(weak,
nonatomic, readonly)
On 2016/11/25 12:56:26, noyau wrote:
> This one also, readonly and weak makes no sense.
> 
> Seriously, this is not behaving like a property, why is it not just a method?

Same reason hundreds of our properties are readonly properties - I don't know :)

[noyau (Ping after 24h), 2016-11-25 14:52:17]

lgtm

[stkhapugin, 2016-11-25 14:57:29]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2016-11-25 14:57:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 16:12:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480085849973870,
"parent_rev": "0f0aa8f6cab6bf736d14f3066d0537314a87ec38", "commit_rev":
"ae4a3d6e3275d85517028cf703cf117b30c39e3a"}

[commit-bot: I haz the power, 2016-11-25 16:12:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-25 16:15:26]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/find_in_page:find_in_page to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/find_in_page:find_in_page to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Committed: https://crrev.com/4c6f265721e5a032d0fe8f138274264db05b7fa1
Cr-Commit-Position: refs/heads/master@{#434517}
==========

[commit-bot: I haz the power, 2016-11-25 16:15:27]

Patchset 3 (id:??) landed as
https://crrev.com/4c6f265721e5a032d0fe8f138274264db05b7fa1
Cr-Commit-Position: refs/heads/master@{#434517}