[ObjC ARC] Converts ios/chrome/browser/find_in_page:find_in_page to ARC.Automatically generated A…

ios/chrome/browser/find_in_page/find_in_page_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/find_in_page/find_in_page_controller.h"
 
 #import <UIKit/UIKit.h>
 
 #import <cmath>
 #include <memory>
 
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
-#include "base/mac/scoped_nsobject.h"
 #import "ios/chrome/browser/find_in_page/find_in_page_model.h"
 #import "ios/chrome/browser/find_in_page/js_findinpage_manager.h"
 #import "ios/chrome/browser/web/dom_altering_lock.h"
 #import "ios/web/public/web_state/crw_web_view_proxy.h"
 #import "ios/web/public/web_state/crw_web_view_scroll_view_proxy.h"
 #import "ios/web/public/web_state/js/crw_js_injection_receiver.h"
 #import "ios/web/public/web_state/web_state.h"
 #import "ios/web/public/web_state/web_state_observer_bridge.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 NSString* const kFindBarTextFieldWillBecomeFirstResponderNotification =
     @"kFindBarTextFieldWillBecomeFirstResponderNotification";
 NSString* const kFindBarTextFieldDidResignFirstResponderNotification =
     @"kFindBarTextFieldDidResignFirstResponderNotification";
 
 namespace {
 // The delay (in secs) after which the find in page string will be pumped again.
 const NSTimeInterval kRecurringPumpDelay = .01;
 
 // Keeps find in page search term to be shared between different tabs. Never
 // reset, not stored on disk.
 static NSString* gSearchTerm;
 }
 
 @interface FindInPageController () <DOMAltering, CRWWebStateObserver>
 // The find in page controller delegate.
 @property(nonatomic, readonly) id<FindInPageControllerDelegate> delegate;
 // The web view's scroll view.
-@property(nonatomic, readonly) CRWWebViewScrollViewProxy* webViewScrollView;
+@property(weak, nonatomic, readonly)

[noyau (Ping after 24h), 2016/11/25 12:56:26]

This one also, readonly and weak makes no sense.

Seriously, this is not behaving like a property, why is it not just a method?

[stkhapugin, 2016/11/25 14:19:39]

Same reason hundreds of our properties are readonly properties - I don't know :)

+    CRWWebViewScrollViewProxy* webViewScrollView;
 
 // Find in Page text field listeners.
 - (void)findBarTextFieldWillBecomeFirstResponder:(NSNotification*)note;
 - (void)findBarTextFieldDidResignFirstResponder:(NSNotification*)note;
 // Keyboard listeners.
 - (void)keyboardDidShow:(NSNotification*)note;
 - (void)keyboardWillHide:(NSNotification*)note;
 // Constantly injects the find string in page until
 // |disableFindInPageWithCompletionHandler:| is called or the find operation is
 // complete. Calls |completionHandler| if the find operation is complete.
@@ skipping 16 matching lines @@
 - (web::WebState*)webState;
 @end
 
 @implementation FindInPageController {
  @private
   // Object that manages find_in_page.js injection into the web view.
   __unsafe_unretained JsFindinpageManager* _findInPageJsManager;
   __unsafe_unretained id<FindInPageControllerDelegate> _delegate;
 
   // Access to the web view from the web state.
-  base::scoped_nsprotocol<id<CRWWebViewProxy>> _webViewProxy;
+  id<CRWWebViewProxy> _webViewProxy;
 
   // True when a find is in progress. Used to avoid running JavaScript during
   // disable when there is nothing to clear.
   BOOL _findStringStarted;
 
   // Bridge to observe the web state from Objective-C.
   std::unique_ptr<web::WebStateObserverBridge> _webStateObserverBridge;
 }
 
 @synthesize delegate = _delegate;
 
 + (void)setSearchTerm:(NSString*)string {
-  [gSearchTerm release];
   gSearchTerm = [string copy];
 }
 
 + (NSString*)searchTerm {
   return gSearchTerm;
 }
 
 - (id)initWithWebState:(web::WebState*)webState
               delegate:(id<FindInPageControllerDelegate>)delegate {
   self = [super init];
   if (self) {
     DCHECK(delegate);
     _findInPageJsManager = base::mac::ObjCCastStrict<JsFindinpageManager>(
         [webState->GetJSInjectionReceiver()
             instanceOfClass:[JsFindinpageManager class]]);
     _delegate = delegate;
     _webStateObserverBridge.reset(
         new web::WebStateObserverBridge(webState, self));
-    _webViewProxy.reset([webState->GetWebViewProxy() retain]);
+    _webViewProxy = webState->GetWebViewProxy();
     [[NSNotificationCenter defaultCenter]
         addObserver:self
            selector:@selector(findBarTextFieldWillBecomeFirstResponder:)
                name:kFindBarTextFieldWillBecomeFirstResponderNotification
              object:nil];
     [[NSNotificationCenter defaultCenter]
         addObserver:self
            selector:@selector(findBarTextFieldDidResignFirstResponder:)
                name:kFindBarTextFieldDidResignFirstResponderNotification
              object:nil];
     DOMAlteringLock::CreateForWebState(webState);
   }
   return self;
 }
 
 - (void)dealloc {
   [[NSNotificationCenter defaultCenter] removeObserver:self];
-  [super dealloc];
 }
 
 - (FindInPageModel*)findInPageModel {
   return [_findInPageJsManager findInPageModel];
 }
 
 - (BOOL)canFindInPage {
   return [_webViewProxy hasSearchableTextContent];
 }
 
@@ skipping 45 matching lines @@
         completionHandler();
       }
       return;
     }
     // Cancel any previous pumping.
     [NSObject cancelPreviousPerformRequestsWithTarget:self];
     [self initFindInPage];
     // Keep track of whether a find is in progress so to avoid running
     // JavaScript during disable if unnecessary.
     _findStringStarted = YES;
-    base::WeakNSObject<FindInPageController> weakSelf(self);
+    __weak FindInPageController* weakSelf = self;
     [_findInPageJsManager findString:query
                    completionHandler:^(BOOL finished, CGPoint point) {
                      [weakSelf processPumpResult:finished
                                      scrollPoint:point
                                completionHandler:completionHandler];
                    }];
   };
   DOMAlteringLock::FromWebState([self webState])->Acquire(self, lockAction);
 }
 
 - (void)startPumpingWithCompletionHandler:(ProceduralBlock)completionHandler {
-  base::WeakNSObject<FindInPageController> weakSelf(self);
+  __weak FindInPageController* weakSelf = self;
   id completionHandlerBlock = ^void(BOOL findFinished) {
     if (findFinished) {
       // Pumping complete. Nothing else to do.
       if (completionHandler)
         completionHandler();
       return;
     }
     // Further pumping is required.
     [weakSelf performSelector:@selector(startPumpingWithCompletionHandler:)
                    withObject:completionHandler
                    afterDelay:kRecurringPumpDelay];
   };
   [self pumpFindStringInPageWithCompletionHandler:completionHandlerBlock];
 }
 
 - (void)pumpFindStringInPageWithCompletionHandler:
     (void (^)(BOOL))completionHandler {
-  base::WeakNSObject<FindInPageController> weakSelf(self);
+  __weak FindInPageController* weakSelf = self;
   [_findInPageJsManager pumpWithCompletionHandler:^(BOOL finished,
                                                     CGPoint point) {
-    base::scoped_nsobject<FindInPageController> strongSelf([weakSelf retain]);
+    FindInPageController* strongSelf = weakSelf;
     if (finished) {
       [[strongSelf delegate] willAdjustScrollPosition];
       point = [strongSelf limitOverscroll:[strongSelf webViewScrollView]
                                   atPoint:point];
       [[strongSelf webViewScrollView] setContentOffset:point animated:YES];
     }
     completionHandler(finished);
   }];
 }
 
 - (void)findNextStringInPageWithCompletionHandler:
     (ProceduralBlock)completionHandler {
   [self initFindInPage];
-  base::WeakNSObject<FindInPageController> weakSelf(self);
+  __weak FindInPageController* weakSelf = self;
   [_findInPageJsManager nextMatchWithCompletionHandler:^(CGPoint point) {
-    base::scoped_nsobject<FindInPageController> strongSelf([weakSelf retain]);
+    FindInPageController* strongSelf = weakSelf;
     [[strongSelf delegate] willAdjustScrollPosition];
     point = [strongSelf limitOverscroll:[strongSelf webViewScrollView]
                                 atPoint:point];
     [[strongSelf webViewScrollView] setContentOffset:point animated:YES];
     if (completionHandler)
       completionHandler();
   }];
 }
 
 // Highlight the previous search match, update model and scroll to match.
 - (void)findPreviousStringInPageWithCompletionHandler:
     (ProceduralBlock)completionHandler {
   [self initFindInPage];
-  base::WeakNSObject<FindInPageController> weakSelf(self);
+  __weak FindInPageController* weakSelf = self;
   [_findInPageJsManager previousMatchWithCompletionHandler:^(CGPoint point) {
-    base::scoped_nsobject<FindInPageController> strongSelf([weakSelf retain]);
+    FindInPageController* strongSelf = weakSelf;
     [[strongSelf delegate] willAdjustScrollPosition];
     point = [strongSelf limitOverscroll:[strongSelf webViewScrollView]
                                 atPoint:point];
     [[strongSelf webViewScrollView] setContentOffset:point animated:YES];
     if (completionHandler)
       completionHandler();
   }];
 }
 
 // Remove highlights from the page and disable the model.
 - (void)disableFindInPageWithCompletionHandler:
     (ProceduralBlock)completionHandler {
   if (![self canFindInPage])
     return;
   // Cancel any queued calls to |recurringPumpWithCompletionHandler|.
   [NSObject cancelPreviousPerformRequestsWithTarget:self];
-  base::WeakNSObject<FindInPageController> weakSelf(self);
+  __weak FindInPageController* weakSelf = self;
   ProceduralBlock handler = ^{
-    base::scoped_nsobject<FindInPageController> strongSelf([weakSelf retain]);
+    FindInPageController* strongSelf = weakSelf;
     if (strongSelf) {
-      [strongSelf.get().findInPageModel setEnabled:NO];
+      [strongSelf.findInPageModel setEnabled:NO];
       web::WebState* webState = [strongSelf webState];
       if (webState)
         DOMAlteringLock::FromWebState(webState)->Release(strongSelf);
     }
     if (completionHandler)
       completionHandler();
   };
   // Only run JSFindInPageManager disable if there is a string in progress to
   // avoid WKWebView crash on deallocation due to outstanding completion
   // handler.
@@ skipping 82 matching lines @@
 
 - (BOOL)canReleaseDOMLock {
   return NO;
 }
 
 - (void)releaseDOMLockWithCompletionHandler:(ProceduralBlock)completionHandler {
   NOTREACHED();
 }
 
 @end