[ObjC ARC] Converts ios/chrome/browser/find_in_page:find_in_page to ARC.Automatically generated A…

ios/chrome/browser/find_in_page/js_findinpage_manager.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/find_in_page/js_findinpage_manager.h"
 
 #include <memory>
 #include <string>
 
 #import "base/ios/weak_nsobject.h"
 #include "base/json/json_reader.h"
 #include "base/json/string_escape.h"
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/values.h"
 #import "ios/chrome/browser/find_in_page/find_in_page_model.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace {
 
 // Initializes Find In Page JavaScript with the width and height of the window.
 NSString* const kFindInPageInit = @"window.__gCrWeb.findInPage && "
                                    "window.__gCrWeb.findInPage.init(%.f, %.f);";
 
 // This will only do verbatim matches.
 // The timeout of 100ms is hardcoded into this string so we don't have
 // to spend any time at runtime to format this constant into another constant.
 NSString* const kFindInPageVerbatim =
@@ skipping 101 matching lines @@
   [self moveHighlightByEvaluatingJavaScript:kFindInPagePrev
                           completionHandler:completionHandler];
 }
 
 - (void)moveHighlightByEvaluatingJavaScript:(NSString*)script
                           completionHandler:
                               (void (^)(CGPoint))completionHandler {
   base::WeakNSObject<JsFindinpageManager> weakSelf(self);
   [self executeJavaScript:script
         completionHandler:^(id result, NSError* error) {
-          base::WeakNSObject<JsFindinpageManager> strongSelf([weakSelf retain]);

[noyau (Ping after 24h), 2016/11/25 10:27:46]

Hu? A supposed "strongSelf" stored in a Weak? This makes no sense.

[stkhapugin, 2016/11/25 11:23:04]

This is the coolest catch!

+          base::WeakNSObject<JsFindinpageManager> strongSelf(weakSelf);
           if (!strongSelf)
             return;
           DCHECK(!error);
           FindInPageEntry entry = kFindInPageEntryZero;
           if (![result isEqual:kFindInPagePending]) {
             NSString* stringResult =
                 base::mac::ObjCCastStrict<NSString>(result);
             entry = [strongSelf findInPageEntryForJson:stringResult];
           }
           CGPoint newPoint = entry.point;
@@ skipping 104 matching lines @@
 }
 
 #pragma mark -
 #pragma mark ProtectedMethods
 
 - (NSString*)scriptPath {
   return @"find_in_page";
 }
 
 @end