Support policies referencing external data for device-local accounts

Support policies referencing external data for device-local accounts

This CL adds a DeviceLocalAccountExternalDataService that provides each
device-local account with a DeviceLocalAccountExternalDataManager which
fetches, caches and retrieves external policy data.

BUG=256635
TEST=New browser test
R=derat@chromium.org, joaodasilva@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233048

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233054

[bartfab (slow), 2013-10-31 20:49:18]

Hi Joao,

Could you please review this CL?

Hi Daniel,

Could you please review chromeos/chromeos_paths.*?

[Daniel Erat, 2013-11-01 13:22:14]

lgtm

[Joao da Silva, 2013-11-04 09:16:50]

lgtm

https://codereview.chromium.org/25242002/diff/3001/chrome/browser/chromeos/po...
File
chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc
(right):

https://codereview.chromium.org/25242002/diff/3001/chrome/browser/chromeos/po...
chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc:26:
destination->reset(data.release());
*destination = data.Pass(); also works

https://codereview.chromium.org/25242002/diff/3001/chrome/browser/policy/clou...
File chrome/browser/policy/cloud/cloud_external_data_manager.cc (right):

https://codereview.chromium.org/25242002/diff/3001/chrome/browser/policy/clou...
chrome/browser/policy/cloud/cloud_external_data_manager.cc:34:
weak_factory_.InvalidateWeakPtrs();
Why?

[bartfab (slow), 2013-11-04 16:03:47]

https://codereview.chromium.org/25242002/diff/3001/chrome/browser/chromeos/po...
File
chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc
(right):

https://codereview.chromium.org/25242002/diff/3001/chrome/browser/chromeos/po...
chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc:26:
destination->reset(data.release());
On 2013/11/04 09:16:51, Joao da Silva wrote:
> *destination = data.Pass(); also works

Done.

https://codereview.chromium.org/25242002/diff/3001/chrome/browser/policy/clou...
File chrome/browser/policy/cloud/cloud_external_data_manager.cc (right):

https://codereview.chromium.org/25242002/diff/3001/chrome/browser/policy/clou...
chrome/browser/policy/cloud/cloud_external_data_manager.cc:34:
weak_factory_.InvalidateWeakPtrs();
On 2013/11/04 09:16:51, Joao da Silva wrote:
> Why?

This method is meant for connecting a store to the manager and for disconnecting
it again. The disconnecting part was not working correctly. When you disconnect
(by passing NULL), the manager would forget about the store but the store would
still have a WeakPtr to the manager. This never was an issue before because the
store and manager had very similar lifetimes. Now that their lifetimes are
decoupled, reliable disconnecting is necessary.

[commit-bot: I haz the power, 2013-11-04 16:11:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/25242002/83001

[commit-bot: I haz the power, 2013-11-04 17:37:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/25242002/83001

[commit-bot: I haz the power, 2013-11-04 19:54:32]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-04 20:11:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/25242002/83001

[commit-bot: I haz the power, 2013-11-05 01:48:33]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-05 10:12:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/25242002/83001

[commit-bot: I haz the power, 2013-11-05 13:26:33]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-05 15:41:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/25242002/83001

[commit-bot: I haz the power, 2013-11-05 15:57:53]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-05 16:02:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/25242002/83001

[commit-bot: I haz the power, 2013-11-05 19:09:53]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[bartfab (slow), 2013-11-05 19:11:30]

Committed patchset #2 manually as r233048 (presubmit successful).

[bartfab (slow), 2013-11-05 19:30:58]

Committed patchset #3 manually as r233054 (presubmit successful).