Support policies referencing external data for device-local accounts

chrome/browser/policy/cloud/cloud_external_data_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/cloud/cloud_external_data_manager.h"
 
 #include "chrome/browser/policy/cloud/cloud_policy_store.h"
 #include "net/url_request/url_request_context_getter.h"
 
 namespace policy {
@@ skipping 13 matching lines @@
 }
 
 CloudExternalDataManager::CloudExternalDataManager() : policy_store_(NULL),
                                                        weak_factory_(this) {
 }
 
 CloudExternalDataManager::~CloudExternalDataManager() {
 }
 
 void CloudExternalDataManager::SetPolicyStore(CloudPolicyStore* policy_store) {
+  weak_factory_.InvalidateWeakPtrs();

[Joao da Silva, 2013/11/04 09:16:51]

Why?

[bartfab (slow), 2013/11/04 16:03:47]

This method is meant for connecting a store to the manager and for disconnecting
it again. The disconnecting part was not working correctly. When you disconnect
(by passing NULL), the manager would forget about the store but the store would
still have a WeakPtr to the manager. This never was an issue before because the
store and manager had very similar lifetimes. Now that their lifetimes are
decoupled, reliable disconnecting is necessary.

   policy_store_ = policy_store;
   if (policy_store_)
     policy_store_->SetExternalDataManager(weak_factory_.GetWeakPtr());
 }
 
 }  // namespace policy