Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2524163002:
Disabling a flaky test (SingleMetaRefreshRedirectTargetBlank) on Linux. (Closed)
|
Created:
4 years ago by Łukasz Anforowicz Modified:
4 years ago Reviewers:
Jialiu Lin CC:
chromium-reviews, grt+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisabling a flaky test (SingleMetaRefreshRedirectTargetBlank) on Linux.
BUG=667784
TBR=jialiul@chromium.org
Committed: https://crrev.com/b0e1c3cbe0d4a71600f5509937157742e4545bc2
Cr-Commit-Position: refs/heads/master@{#434548}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Disabling the right test... #Patch Set 3 : And adding a missing MAYBE_ ... #Messages
Total messages: 31 (16 generated)
jialiul@, I am TBR-ing a CL that disables a flaky test on Linux.
The CQ bit was checked by lukasza@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hi lukasza@, Thanks for disabling flaky test for me, though I think you disabled SingleMetaRefreshRedirect instead of SingleMetaRefreshRedirectTargetBlank. https://codereview.chromium.org/2524163002/diff/1/chrome/browser/safe_browsin... File chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc (right): https://codereview.chromium.org/2524163002/diff/1/chrome/browser/safe_browsin... chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc:341: SingleMetaRefreshRedirectTargetBlank) { I think this is the test you suppose to disable.
The CQ bit was unchecked by lukasza@chromium.org
On 2016/11/23 21:33:58, Jialiu Lin wrote: > Hi lukasza@, > Thanks for disabling flaky test for me, though I think you disabled > SingleMetaRefreshRedirect instead of SingleMetaRefreshRedirectTargetBlank. > > https://codereview.chromium.org/2524163002/diff/1/chrome/browser/safe_browsin... > File > chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc > (right): > > https://codereview.chromium.org/2524163002/diff/1/chrome/browser/safe_browsin... > chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc:341: > SingleMetaRefreshRedirectTargetBlank) { > I think this is the test you suppose to disable. Ooops. Thanks for catching this. I'll fix up the CL in a minute.
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
jialiul@, can you take another look please? https://codereview.chromium.org/2524163002/diff/1/chrome/browser/safe_browsin... File chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc (right): https://codereview.chromium.org/2524163002/diff/1/chrome/browser/safe_browsin... chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc:341: SingleMetaRefreshRedirectTargetBlank) { On 2016/11/23 21:33:58, Jialiu Lin wrote: > I think this is the test you suppose to disable. Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by lukasza@chromium.org
The CQ bit was checked by lukasza@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by lukasza@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by jialiul@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by jialiul@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480098273198490,
"parent_rev": "a715a10714132212e700a04225aa6fae13e06e62", "commit_rev":
"3f3a42a5d5e522510f21703d76f0242c905bf69b"}
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Disabling a flaky test (SingleMetaRefreshRedirectTargetBlank) on Linux. BUG=667784 TBR=jialiul@chromium.org ========== to ========== Disabling a flaky test (SingleMetaRefreshRedirectTargetBlank) on Linux. BUG=667784 TBR=jialiul@chromium.org Committed: https://crrev.com/b0e1c3cbe0d4a71600f5509937157742e4545bc2 Cr-Commit-Position: refs/heads/master@{#434548} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b0e1c3cbe0d4a71600f5509937157742e4545bc2 Cr-Commit-Position: refs/heads/master@{#434548} |
