Disabling a flaky test (SingleMetaRefreshRedirectTargetBlank) on Linux.

chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/safe_browsing/safe_browsing_navigation_observer.h"
 #include "chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h"
@@ skipping 277 matching lines @@
                         GURL(),        // source_main_frame_url
                         download_url,  // original_request_url
                         download_url,  // destination_url
                         false,         // is_user_initiated,
                         false,         // has_committed
                         false,         // has_server_redirect
                         nav_map->at(download_url).at(1));
   VerifyHostToIpMap();
 }
 
+// https://crbug.com/667784: The test is flaky on Linux.
+#if defined(OS_LINUX)
+#define MAYBE_SingleMetaRefreshRedirect DISABLED_SingleMetaRefreshRedirect
+#else
+#define MAYBE_SingleMetaRefreshRedirect SingleMetaRefreshRedirect
+#endif
 // Click on a link which navigates to a page then redirects to a download using
 // META HTTP-EQUIV="refresh". All transitions happen in the same tab.
 IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest,
-                       SingleMetaRefreshRedirect) {
+                       MAYBE_SingleMetaRefreshRedirect) {
   ClickTestLink("single_meta_refresh_redirect", 2);
   GURL initial_url = embedded_test_server()->GetURL(kSingleFrameTestURL);
   GURL redirect_url = embedded_test_server()->GetURL(kRedirectURL);
   GURL download_url = embedded_test_server()->GetURL(kDownloadItemURL);
   auto nav_map = navigation_map();
   ASSERT_TRUE(nav_map);
   // Since unlike server redirects client redirects commit and then generate a
   // second navigation, our observer records two NavigationEvents for this test.
   ASSERT_EQ(std::size_t(2), nav_map->size());
   ASSERT_EQ(std::size_t(1), nav_map->at(redirect_url).size());
@@ skipping 13 matching lines @@
                         false,         // is_user_initiated,
                         false,         // has_committed
                         false,         // has_server_redirect
                         nav_map->at(download_url).at(0));
   VerifyHostToIpMap();
 }
 
 // Click on a link which navigates to a page then redirects to a download using
 // META HTTP-EQUIV="refresh". First navigation happens in target blank.
 IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest,
                        SingleMetaRefreshRedirectTargetBlank) {

[Jialiu Lin, 2016/11/23 21:33:58]

I think this is the test you suppose to disable.

[Łukasz Anforowicz, 2016/11/23 21:43:44]

Done.

   ClickTestLink("single_meta_refresh_redirect_target_blank", 2);
   GURL initial_url = embedded_test_server()->GetURL(kSingleFrameTestURL);
   GURL redirect_url = embedded_test_server()->GetURL(kRedirectURL);
   GURL download_url = embedded_test_server()->GetURL(kDownloadItemURL);
   auto nav_map = navigation_map();
   ASSERT_TRUE(nav_map);
   ASSERT_EQ(std::size_t(2), nav_map->size());
   ASSERT_EQ(std::size_t(2), nav_map->at(redirect_url).size());
   ASSERT_EQ(std::size_t(1), nav_map->at(download_url).size());
   // TODO(jialiul): After https://crbug.com/651895 is fixed, we'll no longer
@@ skipping 422 matching lines @@
           yesterday, embedded_test_server()->host_port_pair().host()));
   ASSERT_EQ(std::size_t(1), ip_map->at(test_server_host).size());
   ClickTestLink("direct_download", 1);
   EXPECT_EQ(std::size_t(1), ip_map->at(test_server_host).size());
   EXPECT_EQ(embedded_test_server()->host_port_pair().host(),
             ip_map->at(test_server_host).back().ip);
   EXPECT_NE(yesterday, ip_map->at(test_server_host).front().timestamp);
 }
 
 }  // namespace safe_browsing