Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4496)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc

Issue 2524163002: Disabling a flaky test (SingleMetaRefreshRedirectTargetBlank) on Linux. (Closed)
Patch Set: And adding a missing MAYBE_ ... Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
index dd7eb32f57217d98049bbb5a605dfc01b813de73..1a09af8108053f658477b01be1cc9d3493878903 100644
--- a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
@@ -329,10 +329,16 @@ IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest,
VerifyHostToIpMap();
}
+// https://crbug.com/667784: The test is flaky on Linux.
+#if defined(OS_LINUX)
+#define MAYBE_SingleMetaRefreshRedirectTargetBlank DISABLED_SingleMetaRefreshRedirectTargetBlank
+#else
+#define MAYBE_SingleMetaRefreshRedirectTargetBlank SingleMetaRefreshRedirectTargetBlank
+#endif
// Click on a link which navigates to a page then redirects to a download using
// META HTTP-EQUIV="refresh". First navigation happens in target blank.
IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest,
- SingleMetaRefreshRedirectTargetBlank) {
+ MAYBE_SingleMetaRefreshRedirectTargetBlank) {
ClickTestLink("single_meta_refresh_redirect_target_blank", 2);
GURL initial_url = embedded_test_server()->GetURL(kSingleFrameTestURL);
GURL redirect_url = embedded_test_server()->GetURL(kRedirectURL);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698