Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2524053002:
Don't update TabSpecificContentSettings on same-page navigation (Closed)
DescriptionDon't update TabSpecificContentSettings on same-page navigation
This CL ensures that the TabSpecificContentSettings are not updated when
navigating same-page. This fixes an issue where the location tracking
icon would disappear when accepting to send location info to Google
search. This is because Google search would do a fragment navigation
when location tracking was accepted, which would fire DidStartNavigation
causing the location information to be reset. Previously,
DidStartProvisionalLoad would not be called for a fragment navigation,
so the icon would not be reset.
For the record, TabSpecificContentSettings was made to use DidStartNavigation
in https://codereview.chromium.org/2374443003.
BUG=667256
Committed: https://crrev.com/d796bf464ffe66b896c8def42b1f916f62da9928
Cr-Commit-Position: refs/heads/master@{#434208}
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
The CQ bit was checked by clamy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Don't update TabSpecificContentSettings on same-page navigation This CL ensures that the TabSpecificContentSettings are not updated when navigating same-page. This fixes an issue where the location tracking icon would disappear when accepting to send location info to Google search. This is because Google search would do a fragment navigation when location tracking was accepted, which would fire DidStartNavigation causing the location information to be reset. Previously, DidStartProvisionalLoad would not be called for a fragment navigation, so the icon would not be reset. BUG=667256 ========== to ========== Don't update TabSpecificContentSettings on same-page navigation This CL ensures that the TabSpecificContentSettings are not updated when navigating same-page. This fixes an issue where the location tracking icon would disappear when accepting to send location info to Google search. This is because Google search would do a fragment navigation when location tracking was accepted, which would fire DidStartNavigation causing the location information to be reset. Previously, DidStartProvisionalLoad would not be called for a fragment navigation, so the icon would not be reset. For the record, TabSpecificContentSettings was made to use DidStartNavigation in https://codereview.chromium.org/2374443003. BUG=667256 ==========
Description was changed from ========== Don't update TabSpecificContentSettings on same-page navigation This CL ensures that the TabSpecificContentSettings are not updated when navigating same-page. This fixes an issue where the location tracking icon would disappear when accepting to send location info to Google search. This is because Google search would do a fragment navigation when location tracking was accepted, which would fire DidStartNavigation causing the location information to be reset. Previously, DidStartProvisionalLoad would not be called for a fragment navigation, so the icon would not be reset. For the record, TabSpecificContentSettings was made to use DidStartNavigation in https://codereview.chromium.org/2374443003. BUG=667256 ========== to ========== Don't update TabSpecificContentSettings on same-page navigation This CL ensures that the TabSpecificContentSettings are not updated when navigating same-page. This fixes an issue where the location tracking icon would disappear when accepting to send location info to Google search. This is because Google search would do a fragment navigation when location tracking was accepted, which would fire DidStartNavigation causing the location information to be reset. Previously, DidStartProvisionalLoad would not be called for a fragment navigation, so the icon would not be reset. For the record, TabSpecificContentSettings was made to use DidStartNavigation in https://codereview.chromium.org/2374443003. BUG=667256 ==========
clamy@chromium.org changed reviewers: + sky@chromium.org
bauerb@chromium.org changed reviewers: + bauerb@chromium.org
Drive-by LGTM, thanks! :)
clamy@chromium.org changed reviewers: - bauerb@chromium.org
@sky: could you PTAL at this today? This is the fix for an M55 stable blocker that was discovered recently and needs to be merged ASAP (ideally today if the code is okay). I couldn't add any reviewers for that specific directory because they are all in EMEA time. Also, if you're happy with the patch, could you send it to CQ (I'm also on EMEA time). Thanks!
@sky: well an owner did a drive-by lgtm while I was writing the review message, so no longer need a review, thanks :)!
The CQ bit was unchecked by clamy@chromium.org
The CQ bit was checked by clamy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479923064833760, "parent_rev":
"b9c2c0480c17adecf6aae184d8573e6a27080da6", "commit_rev":
"774e5b312d62d8b4e45da1927ae769faa03f2b14"}
Message was sent while issue was closed.
Description was changed from ========== Don't update TabSpecificContentSettings on same-page navigation This CL ensures that the TabSpecificContentSettings are not updated when navigating same-page. This fixes an issue where the location tracking icon would disappear when accepting to send location info to Google search. This is because Google search would do a fragment navigation when location tracking was accepted, which would fire DidStartNavigation causing the location information to be reset. Previously, DidStartProvisionalLoad would not be called for a fragment navigation, so the icon would not be reset. For the record, TabSpecificContentSettings was made to use DidStartNavigation in https://codereview.chromium.org/2374443003. BUG=667256 ========== to ========== Don't update TabSpecificContentSettings on same-page navigation This CL ensures that the TabSpecificContentSettings are not updated when navigating same-page. This fixes an issue where the location tracking icon would disappear when accepting to send location info to Google search. This is because Google search would do a fragment navigation when location tracking was accepted, which would fire DidStartNavigation causing the location information to be reset. Previously, DidStartProvisionalLoad would not be called for a fragment navigation, so the icon would not be reset. For the record, TabSpecificContentSettings was made to use DidStartNavigation in https://codereview.chromium.org/2374443003. BUG=667256 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Don't update TabSpecificContentSettings on same-page navigation This CL ensures that the TabSpecificContentSettings are not updated when navigating same-page. This fixes an issue where the location tracking icon would disappear when accepting to send location info to Google search. This is because Google search would do a fragment navigation when location tracking was accepted, which would fire DidStartNavigation causing the location information to be reset. Previously, DidStartProvisionalLoad would not be called for a fragment navigation, so the icon would not be reset. For the record, TabSpecificContentSettings was made to use DidStartNavigation in https://codereview.chromium.org/2374443003. BUG=667256 ========== to ========== Don't update TabSpecificContentSettings on same-page navigation This CL ensures that the TabSpecificContentSettings are not updated when navigating same-page. This fixes an issue where the location tracking icon would disappear when accepting to send location info to Google search. This is because Google search would do a fragment navigation when location tracking was accepted, which would fire DidStartNavigation causing the location information to be reset. Previously, DidStartProvisionalLoad would not be called for a fragment navigation, so the icon would not be reset. For the record, TabSpecificContentSettings was made to use DidStartNavigation in https://codereview.chromium.org/2374443003. BUG=667256 Committed: https://crrev.com/d796bf464ffe66b896c8def42b1f916f62da9928 Cr-Commit-Position: refs/heads/master@{#434208} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d796bf464ffe66b896c8def42b1f916f62da9928 Cr-Commit-Position: refs/heads/master@{#434208} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
