[Mojo Video Capture] Move SharedMem Tracker/BufferHandle/Factory from content to media

[Mojo Video Capture] Move SharedMem Tracker/BufferHandle/Factory from content to media

Moved classes SharedMemoryBufferTracker, SharedMemoryBufferHandle, and VideoCaptureBufferTrackerFactoryImpl from content/browser/renderer_host/media
to media/capture/video in order to make them reusable in the Mojo service.

Fixed header guard in a few files in media/capture/video.

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL1.9.5c

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Committed: https://crrev.com/e46d5ad41d9f0fd575027ceab41f8e2a8c0695c4
Cr-Commit-Position: refs/heads/master@{#434278}

[chfremer, 2016-11-22 17:29:23]

Description was changed from

==========
presubmit


Merge branch '1.9.5b' into 1.9.5c


Merge branch '1.9.5b' into 1.9.5c


Merge branch '1.9.5b' into 1.9.5c


Merge branch '1.9.5b' into 1.9.5c


Merge branch '1.9.5b' into 1.9.5c


Merge branch '1.9.5b' into 1.9.5c


Merge branch '1.9.5b' into 1.9.5c


Move shared memory buffer tracker from content to media.

BUG=
==========

to

==========
[Mojo Video Capture] Move SharedMem Tracker/BufferHandle/Factory from content to
media

Moved classes SharedMemoryBufferTracker, SharedMemoryBufferHandle, and
VideoCaptureBufferTrackerFactoryImpl from content/browser/renderer_host/media 
to media/capture/video in order to make them reusable in the Mojo service.

Fixed header guard in a few files in media/capture/video.

This CL is part of the Mojo Video Capture work. For the bigger picture, 
see [1] CL1.9.5c

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

[chfremer, 2016-11-22 17:30:16]

chfremer@chromium.org changed reviewers:
+ mcasas@chromium.org

[chfremer, 2016-11-22 17:30:17]

mcasas: PTAL

[mcasas, 2016-11-23 17:23:56]

lgtm

https://codereview.chromium.org/2523773002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc
(right):

https://codereview.chromium.org/2523773002/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc:1: //
Copyright (c) 2013 The Chromium Authors. All rights reserved.
Why not move the unittests together with the implementation?
It's a sign of too much (bad) coupling that we need here
e.g. video_capture_controller.h for a unittest :(
I understand this might be an issue predating this CL, so
I'm happy if it happens in subsequent CLs :)

https://codereview.chromium.org/2523773002/diff/20001/media/capture/video/sha...
File media/capture/video/shared_memory_buffer_tracker.cc (right):

https://codereview.chromium.org/2523773002/diff/20001/media/capture/video/sha...
media/capture/video/shared_memory_buffer_tracker.cc:59: DCHECK_EQ(plane, 0);
nit: DCHECK_EQ(expected, actual).

https://codereview.chromium.org/2523773002/diff/20001/media/capture/video/vid...
File media/capture/video/video_capture_buffer_tracker_factory_impl.cc (right):

https://codereview.chromium.org/2523773002/diff/20001/media/capture/video/vid...
media/capture/video/video_capture_buffer_tracker_factory_impl.cc:15:
DCHECK_EQ(media::PIXEL_STORAGE_CPU, storage);
nit: no need for media:: here.

[chfremer, 2016-11-23 17:42:56]

Addressed mcasas@ comments

https://codereview.chromium.org/2523773002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc
(right):

https://codereview.chromium.org/2523773002/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc:1: //
Copyright (c) 2013 The Chromium Authors. All rights reserved.
On 2016/11/23 17:23:56, mcasas wrote:
> Why not move the unittests together with the implementation?
> It's a sign of too much (bad) coupling that we need here
> e.g. video_capture_controller.h for a unittest :(
> I understand this might be an issue predating this CL, so
> I'm happy if it happens in subsequent CLs :)

Note the comment starting at line 48.
Despite the name, this is not a test of VideoCaptureBufferPool in isolation.

It is true that this test predates the refactoring that removed the hard
coupling between VideoCaptureBufferPool and the code in content/... and moved it
out to media. It should now be easier to author tests that exercise
VideoCaptureBufferPool in isolation. We just don't have any right now. Instead
we have this test of a larger unit here, which cannot be moved to where
VideoCaptureBufferPool lives now. This test is still as valuable as before. It
just is not (and never was) a unit test of VideoCaptureBufferPool.

https://codereview.chromium.org/2523773002/diff/20001/media/capture/video/sha...
File media/capture/video/shared_memory_buffer_tracker.cc (right):

https://codereview.chromium.org/2523773002/diff/20001/media/capture/video/sha...
media/capture/video/shared_memory_buffer_tracker.cc:59: DCHECK_EQ(plane, 0);
On 2016/11/23 17:23:56, mcasas wrote:
> nit: DCHECK_EQ(expected, actual).

Done.

https://codereview.chromium.org/2523773002/diff/20001/media/capture/video/vid...
File media/capture/video/video_capture_buffer_tracker_factory_impl.cc (right):

https://codereview.chromium.org/2523773002/diff/20001/media/capture/video/vid...
media/capture/video/video_capture_buffer_tracker_factory_impl.cc:15:
DCHECK_EQ(media::PIXEL_STORAGE_CPU, storage);
On 2016/11/23 17:23:56, mcasas wrote:
> nit: no need for media:: here.

Done.

[chfremer, 2016-11-23 17:44:37]

chfremer@chromium.org changed reviewers:
+ avi@chromium.org

[chfremer, 2016-11-23 17:44:37]

avi@chromium.org: Please RS
* content/browser/BUILD.gn
* content/browser/media/capture/web_contents_video_capture_device_unittest.cc

[chfremer, 2016-11-23 17:48:14]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 17:48:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-11-23 18:35:59]

lgtm

stampity stamp

[commit-bot: I haz the power, 2016-11-23 21:54:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 21:54:24]

Dry run: This issue passed the CQ dry run.

[chfremer, 2016-11-23 21:59:17]

The CQ bit was checked by chfremer@chromium.org

[chfremer, 2016-11-23 21:59:18]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2523773002/#ps40001
(title: "mcasas comments")

[commit-bot: I haz the power, 2016-11-23 22:00:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 23:40:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479938357944970,
"parent_rev": "bae494e43db1e893118e9adf2639aaf4e317e721", "commit_rev":
"65ae5eb442882f1c49e8ddc45f7026ac5f1f4b64"}

[commit-bot: I haz the power, 2016-11-23 23:40:59]

Description was changed from

==========
[Mojo Video Capture] Move SharedMem Tracker/BufferHandle/Factory from content to
media

Moved classes SharedMemoryBufferTracker, SharedMemoryBufferHandle, and
VideoCaptureBufferTrackerFactoryImpl from content/browser/renderer_host/media 
to media/capture/video in order to make them reusable in the Mojo service.

Fixed header guard in a few files in media/capture/video.

This CL is part of the Mojo Video Capture work. For the bigger picture, 
see [1] CL1.9.5c

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
[Mojo Video Capture] Move SharedMem Tracker/BufferHandle/Factory from content to
media

Moved classes SharedMemoryBufferTracker, SharedMemoryBufferHandle, and
VideoCaptureBufferTrackerFactoryImpl from content/browser/renderer_host/media 
to media/capture/video in order to make them reusable in the Mojo service.

Fixed header guard in a few files in media/capture/video.

This CL is part of the Mojo Video Capture work. For the bigger picture, 
see [1] CL1.9.5c

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

[commit-bot: I haz the power, 2016-11-23 23:41:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-23 23:42:14]

Description was changed from

==========
[Mojo Video Capture] Move SharedMem Tracker/BufferHandle/Factory from content to
media

Moved classes SharedMemoryBufferTracker, SharedMemoryBufferHandle, and
VideoCaptureBufferTrackerFactoryImpl from content/browser/renderer_host/media 
to media/capture/video in order to make them reusable in the Mojo service.

Fixed header guard in a few files in media/capture/video.

This CL is part of the Mojo Video Capture work. For the bigger picture, 
see [1] CL1.9.5c

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
[Mojo Video Capture] Move SharedMem Tracker/BufferHandle/Factory from content to
media

Moved classes SharedMemoryBufferTracker, SharedMemoryBufferHandle, and
VideoCaptureBufferTrackerFactoryImpl from content/browser/renderer_host/media
to media/capture/video in order to make them reusable in the Mojo service.

Fixed header guard in a few files in media/capture/video.

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL1.9.5c

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...

Committed: https://crrev.com/e46d5ad41d9f0fd575027ceab41f8e2a8c0695c4
Cr-Commit-Position: refs/heads/master@{#434278}
==========

[commit-bot: I haz the power, 2016-11-23 23:42:15]

Patchset 3 (id:??) landed as
https://crrev.com/e46d5ad41d9f0fd575027ceab41f8e2a8c0695c4
Cr-Commit-Position: refs/heads/master@{#434278}