[Mojo Video Capture] Move SharedMem Tracker/BufferHandle/Factory from content to media

content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

[mcasas, 2016/11/23 17:23:56]

Why not move the unittests together with the implementation?
It's a sign of too much (bad) coupling that we need here
e.g. video_capture_controller.h for a unittest :(
I understand this might be an issue predating this CL, so
I'm happy if it happens in subsequent CLs :)

[chfremer, 2016/11/23 17:42:56]

Note the comment starting at line 48.
Despite the name, this is not a test of VideoCaptureBufferPool in isolation.

It is true that this test predates the refactoring that removed the hard
coupling between VideoCaptureBufferPool and the code in content/... and moved it
out to media. It should now be easier to author tests that exercise
VideoCaptureBufferPool in isolation. We just don't have any right now. Instead
we have this test of a larger unit here, which cannot be moved to where
VideoCaptureBufferPool lives now. This test is still as valuable as before. It
just is not (and never was) a unit test of VideoCaptureBufferPool.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Unit test for VideoCaptureBufferPool.
 
 #include "media/capture/video/video_capture_buffer_pool.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <string.h>
 
 #include <memory>
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
 #include "build/build_config.h"
 #include "cc/test/test_context_provider.h"
 #include "cc/test/test_web_graphics_context_3d.h"
 #include "components/display_compositor/buffer_queue.h"
-#include "content/browser/renderer_host/media/video_capture_buffer_tracker_factory_impl.h"
 #include "content/browser/renderer_host/media/video_capture_controller.h"
 #include "media/base/video_frame.h"
 #include "media/capture/video/video_capture_buffer_pool_impl.h"
+#include "media/capture/video/video_capture_buffer_tracker_factory_impl.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace content {
 
 struct PixelFormatAndStorage {
   media::VideoPixelFormat pixel_format;
   media::VideoPixelStorage pixel_storage;
 };
 
@@ skipping 26 matching lines @@
 
    private:
     const int id_;
     const scoped_refptr<media::VideoCaptureBufferPool> pool_;
     const std::unique_ptr<media::VideoCaptureBufferHandle> buffer_handle_;
   };
 
   VideoCaptureBufferPoolTest()
       : expected_dropped_id_(0),
         pool_(new media::VideoCaptureBufferPoolImpl(
-            base::MakeUnique<VideoCaptureBufferTrackerFactoryImpl>(),
+            base::MakeUnique<media::VideoCaptureBufferTrackerFactoryImpl>(),
             kTestBufferPoolSize)) {}
 
   void ExpectDroppedId(int expected_dropped_id) {
     expected_dropped_id_ = expected_dropped_id;
   }
 
   std::unique_ptr<Buffer> ReserveBuffer(
       const gfx::Size& dimensions,
       PixelFormatAndStorage format_and_storage) {
     // To verify that ReserveBuffer always sets |buffer_id_to_drop|,
@@ skipping 321 matching lines @@
   ASSERT_NE(nullptr, held_buffers.back().get());
   resurrected = ResurrectLastBuffer(gfx::Size(10, 10), GetParam());
   ASSERT_EQ(nullptr, resurrected.get());
 }
 
 INSTANTIATE_TEST_CASE_P(,
                         VideoCaptureBufferPoolTest,
                         testing::ValuesIn(kCapturePixelFormatAndStorages));
 
 } // namespace content