Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2524103002: [Mojo Video Capture] Move Mojo struct VideoFrameInfo from content/common to media/capture/mojo (Closed)

Created:
4 years ago by chfremer
Modified:
4 years ago
Reviewers:
Tom Sepez, mcasas
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, darin (slow to review), miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mojo Video Capture] Move Mojo struct VideoFrameInfo from content/common to media/capture/mojo Move struct VideoFrameInfo from content/common/video_capture.mojom to media/capture/mojo/video_capture_types.mojom. This will allow us to use the struct in code that transports frames through the browser-process. This will, in turn, allow us to (in a later CL) switch between the existing in-process implementation and the new Mojo service. This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.9.6 BUG=584797 TEST=video_capture_unittests, content_unittests, capture_unittests [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing Committed: https://crrev.com/d5d01f971b371c02a1e80c7ad2d748aed7f69d38 Cr-Commit-Position: refs/heads/master@{#434707}

Patch Set 1 #

Messages

Total messages: 18 (11 generated)
chfremer
mcasas@: PTAL
4 years ago (2016-11-23 17:59:47 UTC) #3
mcasas
lgtm but, bots?
4 years ago (2016-11-23 21:02:00 UTC) #4
chfremer
tsepez@: Please RS *.mojom
4 years ago (2016-11-24 00:26:14 UTC) #10
Tom Sepez
mojom LGTM
4 years ago (2016-11-28 17:10:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524103002/1
4 years ago (2016-11-28 17:14:58 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 20:25:36 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-28 20:29:32 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5d01f971b371c02a1e80c7ad2d748aed7f69d38
Cr-Commit-Position: refs/heads/master@{#434707}

Powered by Google App Engine
This is Rietveld 408576698