Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: include/v8-inspector.h

Issue 2523583005: Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48 (Closed)
Patch Set: added default implementation Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/injected-script.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-inspector.h
diff --git a/include/v8-inspector.h b/include/v8-inspector.h
index 0855ac101b74ef11bf7dccbf13ce02e92e4498d0..c367451cbc6780115c86d54c2b3fa7fd30733d83 100644
--- a/include/v8-inspector.h
+++ b/include/v8-inspector.h
@@ -248,9 +248,15 @@ class V8_EXPORT V8Inspector {
class V8_EXPORT Channel {
public:
virtual ~Channel() {}
- virtual void sendProtocolResponse(int callId,
- const StringView& message) = 0;
- virtual void sendProtocolNotification(const StringView& message) = 0;
+ virtual void sendProtocolResponse(int callId, const StringView& message) {}
+ virtual void sendProtocolNotification(const StringView& message) {}
+ virtual void sendResponse(int callId,
+ std::unique_ptr<StringBuffer> message) {
+ sendProtocolResponse(callId, message->string());
+ }
+ virtual void sendNotification(std::unique_ptr<StringBuffer> message) {
+ sendProtocolNotification(message->string());
+ }
virtual void flushProtocolNotifications() = 0;
};
virtual std::unique_ptr<V8InspectorSession> connect(
« no previous file with comments | « no previous file | src/inspector/injected-script.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698