Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

Issue 2523573003: Use logicalBottom when computing baselines in vertical-lr inline-blocks (Closed)
Patch Set: Platform baselines for the new layout test. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
index c82fb1e91220dc534395ae116707bd733da56d94..956c40f4b4c2b7a51b4f61842b82d25950f68233 100644
--- a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
+++ b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
@@ -769,6 +769,8 @@ void InlineFlowBox::placeBoxesInBlockDirection(
// m_layoutObject.isHorizontalWritingMode(). crbug.com/552954
// ASSERT(curr->isHorizontal() ==
// curr->getLineLayoutItem().style()->isHorizontalWritingMode());
+ // InlineFlowBox::placeBoxesInBlockDirection will flip lines in
mstensho (USE GERRIT) 2016/12/02 11:38:03 InlineFlowBox::placeBoxesInBlockDirection happens
jfernandez 2016/12/05 23:57:28 :) Yes, better said that way.
+ // case of verticalLR mode, so we can assume verticalRL for now.
LayoutUnit overSideMargin =
curr->isHorizontal() ? box.marginTop() : box.marginRight();
LayoutUnit underSideMargin =

Powered by Google App Engine
This is Rietveld 408576698