Use logicalBottom when computing baselines in vertical-lr inline-blocks

third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
index c642ec88a47a0df38f3b2fdb82a4712b5ca6d786..c16d18566bae582741c66c5fa2c4a98ae709705a 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
@@ -2563,7 +2563,11 @@ int LayoutBlockFlow::inlineBlockBaseline(
     DCHECK(fontData);
     if (!fontData)
       return -1;
-    return (lastLineBox()->logicalTop() +
+    // InlineFlowBox::placeBoxesInBlockDirection will flip lines in
+    // case of verticalLR mode, so we can assume verticalRL for now.
+    return ((style()->isFlippedLinesWritingMode()

[mstensho (USE GERRIT), 2016/12/02 11:38:03]

This expression now became very complex. Maybe you could split it into bite
sizes?

[jfernandez, 2016/12/05 23:57:28]

Acknowledged.

+                 ? logicalHeight() - lastLineBox()->logicalBottom()
+                 : lastLineBox()->logicalTop()) +
             fontData->getFontMetrics().ascent(lastRootBox()->baselineType()))
         .toInt();
   }