Use logicalBottom when computing baselines in vertical-lr inline-blocks

third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
  *               All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 751 matching lines @@
         borderPaddingHeight = boxObject.borderAndPaddingLogicalHeight();
       }
       newLogicalTopIncludingMargins = newLogicalTop;
     } else if (!curr->getLineLayoutItem().isBR()) {
       LineLayoutBox box = LineLayoutBox(curr->getLineLayoutItem());
       newLogicalTopIncludingMargins = newLogicalTop;
       // TODO(kojii): isHorizontal() does not match to
       // m_layoutObject.isHorizontalWritingMode(). crbug.com/552954
       // ASSERT(curr->isHorizontal() ==
       // curr->getLineLayoutItem().style()->isHorizontalWritingMode());
+      // InlineFlowBox::placeBoxesInBlockDirection will flip lines in

[mstensho (USE GERRIT), 2016/12/02 11:38:03]

InlineFlowBox::placeBoxesInBlockDirection happens to be this method. :)

So, maybe "We will flip ...".

[jfernandez, 2016/12/05 23:57:28]

:) Yes, better said that way.

+      // case of verticalLR mode, so we can assume verticalRL for now.
       LayoutUnit overSideMargin =
           curr->isHorizontal() ? box.marginTop() : box.marginRight();
       LayoutUnit underSideMargin =
           curr->isHorizontal() ? box.marginBottom() : box.marginLeft();
       newLogicalTop += overSideMargin;
       boxHeightIncludingMargins += overSideMargin + underSideMargin;
     }
 
     curr->setLogicalTop(newLogicalTop);
 
@@ skipping 860 matching lines @@
     ASSERT(child->prevOnLine() == prev);
     prev = child;
   }
   ASSERT(prev == m_lastChild);
 #endif
 }
 
 #endif
 
 }  // namespace blink