Use logicalBottom when computing baselines in vertical-lr inline-blocks

third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 2545 matching lines @@
   if (isWritingModeRoot() && !isRubyRun())
     return -1;
   if (!childrenInline())
     return LayoutBlock::inlineBlockBaseline(lineDirection);
   if (lastLineBox()) {
     const SimpleFontData* fontData =
         style(lastLineBox() == firstLineBox())->font().primaryFont();
     DCHECK(fontData);
     if (!fontData)
       return -1;
-    return (lastLineBox()->logicalTop() +
+    // InlineFlowBox::placeBoxesInBlockDirection will flip lines in
+    // case of verticalLR mode, so we can assume verticalRL for now.
+    return ((style()->isFlippedLinesWritingMode()

[mstensho (USE GERRIT), 2016/12/02 11:38:03]

This expression now became very complex. Maybe you could split it into bite
sizes?

[jfernandez, 2016/12/05 23:57:28]

Acknowledged.

+                 ? logicalHeight() - lastLineBox()->logicalBottom()
+                 : lastLineBox()->logicalTop()) +
             fontData->getFontMetrics().ascent(lastRootBox()->baselineType()))
         .toInt();
   }
   if (!hasLineIfEmpty())
     return -1;
 
   const SimpleFontData* fontData = firstLineStyle()->font().primaryFont();
   DCHECK(fontData);
   if (!fontData)
     return -1;
@@ skipping 1961 matching lines @@
   return LayoutBlock::invalidatePaintIfNeeded(paintInvalidationState);
 }
 
 void LayoutBlockFlow::invalidateDisplayItemClients(
     PaintInvalidationReason invalidationReason) const {
   BlockFlowPaintInvalidator(*this).invalidateDisplayItemClients(
       invalidationReason);
 }
 
 }  // namespace blink