Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2522763005: [Extensions] Remove the source_tab_id property on API request messages (Closed)

Created:
4 years ago by Devlin
Modified:
4 years ago
Reviewers:
lazyboy, dcheng
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove the source_tab_id property on API request messages ExtensionHostMsg_Request_Params includes a "source_tab_id", but this shouldn't be necessary. The browser can determine the tab id from which RFH sent the request. Remove the property. BUG=667584 Committed: https://crrev.com/5eb66dfa480bed01684c4ae1e44599e613e9d5a6 Cr-Commit-Position: refs/heads/master@{#434688}

Patch Set 1 #

Patch Set 2 : foo #

Patch Set 3 : compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M extensions/browser/extension_function.h View 2 chunks +0 lines, -6 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/extension_function_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/extension_messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/renderer/native_extension_bindings_system.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
M extensions/renderer/native_extension_bindings_system_unittest.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/renderer/request_sender.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 29 (18 generated)
Devlin
lazyboy@ (extensions) and dcheng@ (extension_messages.h), mind taking a look?
4 years ago (2016-11-23 22:08:37 UTC) #11
Devlin
lazyboy@ (extensions) and dcheng@ (extension_messages.h), mind taking a look?
4 years ago (2016-11-23 22:18:42 UTC) #12
lazyboy
extensions lgtm
4 years ago (2016-11-24 00:02:14 UTC) #13
dcheng
lgtm
4 years ago (2016-11-24 00:04:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522763005/40001
4 years ago (2016-11-24 00:09:20 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-24 02:10:45 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522763005/40001
4 years ago (2016-11-24 06:26:49 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-24 08:27:57 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522763005/40001
4 years ago (2016-11-28 17:07:24 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-28 18:05:26 UTC) #27
commit-bot: I haz the power
4 years ago (2016-11-28 18:08:39 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5eb66dfa480bed01684c4ae1e44599e613e9d5a6
Cr-Commit-Position: refs/heads/master@{#434688}

Powered by Google App Engine
This is Rietveld 408576698