Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3560)

Unified Diff: extensions/renderer/native_extension_bindings_system.cc

Issue 2522763005: [Extensions] Remove the source_tab_id property on API request messages (Closed)
Patch Set: compile Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/native_extension_bindings_system.cc
diff --git a/extensions/renderer/native_extension_bindings_system.cc b/extensions/renderer/native_extension_bindings_system.cc
index 3a834de5dfe75e6bb479c8a17cff5def6caeb09c..6ea3f5f371d7dae8d3d625888efff39794ef2cf9 100644
--- a/extensions/renderer/native_extension_bindings_system.cc
+++ b/extensions/renderer/native_extension_bindings_system.cc
@@ -10,7 +10,6 @@
#include "extensions/common/extension_api.h"
#include "extensions/common/extension_messages.h"
#include "extensions/common/features/feature_provider.h"
-#include "extensions/renderer/extension_frame_helper.h"
#include "extensions/renderer/script_context.h"
#include "extensions/renderer/script_context_set.h"
#include "gin/converter.h"
@@ -180,20 +179,11 @@ void NativeExtensionBindingsSystem::SendRequest(
else
url = script_context->url();
- int tab_id = -1;
- if (content::RenderFrame* render_frame = script_context->GetRenderFrame()) {
- ExtensionFrameHelper* frame_helper =
- ExtensionFrameHelper::Get(render_frame);
- DCHECK(frame_helper);
- tab_id = frame_helper->tab_id();
- }
-
ExtensionHostMsg_Request_Params params;
params.name = request->method_name;
params.arguments.Swap(request->arguments.get());
params.extension_id = script_context->GetExtensionID();
params.source_url = url;
- params.source_tab_id = tab_id;
params.request_id = request->request_id;
params.has_callback = request->has_callback;
params.user_gesture = request->has_user_gesture;
« no previous file with comments | « extensions/common/extension_messages.h ('k') | extensions/renderer/native_extension_bindings_system_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698