Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: extensions/renderer/native_extension_bindings_system_unittest.cc

Issue 2522763005: [Extensions] Remove the source_tab_id property on API request messages (Closed)
Patch Set: compile Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/native_extension_bindings_system.cc ('k') | extensions/renderer/request_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/native_extension_bindings_system_unittest.cc
diff --git a/extensions/renderer/native_extension_bindings_system_unittest.cc b/extensions/renderer/native_extension_bindings_system_unittest.cc
index 64fbeb500c418e41b079099694c0e0e20a7eb134..a4b85566b852b78610a56f1074f18319d8085c98 100644
--- a/extensions/renderer/native_extension_bindings_system_unittest.cc
+++ b/extensions/renderer/native_extension_bindings_system_unittest.cc
@@ -75,7 +75,6 @@ class NativeExtensionBindingsSystemUnittest : public APIBindingTest {
last_params_.arguments.Swap(params.arguments.CreateDeepCopy().get());
last_params_.extension_id = params.extension_id;
last_params_.source_url = params.source_url;
- last_params_.source_tab_id = params.source_tab_id;
last_params_.request_id = params.request_id;
last_params_.has_callback = params.has_callback;
last_params_.user_gesture = params.user_gesture;
@@ -173,7 +172,6 @@ TEST_F(NativeExtensionBindingsSystemUnittest, Basic) {
EXPECT_EQ(extension->id(), last_params().extension_id);
EXPECT_EQ("idle.queryState", last_params().name);
EXPECT_EQ(extension->url(), last_params().source_url);
- EXPECT_EQ(-1, last_params().source_tab_id);
EXPECT_TRUE(last_params().has_callback);
EXPECT_TRUE(
last_params().arguments.Equals(ListValueFromString("[30]").get()));
« no previous file with comments | « extensions/renderer/native_extension_bindings_system.cc ('k') | extensions/renderer/request_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698