Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2004)

Unified Diff: content/renderer/media/gpu/rtc_video_encoder.cc

Issue 2521923002: Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/gpu/rtc_video_encoder.cc
diff --git a/content/renderer/media/gpu/rtc_video_encoder.cc b/content/renderer/media/gpu/rtc_video_encoder.cc
index f9b5f7268a8132d05a805f8ff8d3c913ea3603c7..4c42938e2a4bef07048703ba1fb759c6d4448135 100644
--- a/content/renderer/media/gpu/rtc_video_encoder.cc
+++ b/content/renderer/media/gpu/rtc_video_encoder.cc
@@ -32,6 +32,25 @@
namespace {
+// Translate from webrtc::VideoCodecType and webrtc::VideoCodec to
+// media::VideoCodecProfile.
+media::VideoCodecProfile WebRTCVideoCodecToVideoCodecProfile(
+ webrtc::VideoCodecType type,
+ const webrtc::VideoCodec* codec_settings) {
+ DCHECK_EQ(type, codec_settings->codecType);
+ switch (type) {
+ case webrtc::kVideoCodecVP8:
+ return media::VP8PROFILE_ANY;
+ case webrtc::kVideoCodecH264:
+ // TODO(magjed): WebRTC is only using Baseline profile for now. Update
+ // once http://crbug/webrtc/6337 is fixed.
+ return media::H264PROFILE_BASELINE;
+ default:
+ NOTREACHED() << "Unrecognized video codec type";
+ return media::VIDEO_CODEC_PROFILE_UNKNOWN;
+ }
+}
+
// Populates struct webrtc::RTPFragmentationHeader for H264 codec.
// Each entry specifies the offset and length (excluding start code) of a NALU.
// Returns true if successful.
@@ -117,6 +136,8 @@
// Return the status of Impl. One of WEBRTC_VIDEO_CODEC_XXX value.
int32_t GetStatus() const;
+
+ webrtc::VideoCodecType video_codec_type() { return video_codec_type_; }
// media::VideoEncodeAccelerator::Client implementation.
void RequireBitstreamBuffers(unsigned int input_count,
@@ -706,12 +727,12 @@
}
RTCVideoEncoder::RTCVideoEncoder(
- media::VideoCodecProfile profile,
+ webrtc::VideoCodecType type,
media::GpuVideoAcceleratorFactories* gpu_factories)
- : profile_(profile),
+ : video_codec_type_(type),
gpu_factories_(gpu_factories),
gpu_task_runner_(gpu_factories->GetTaskRunner()) {
- DVLOG(1) << "RTCVideoEncoder(): profile=" << GetProfileName(profile);
+ DVLOG(1) << "RTCVideoEncoder(): codec type=" << type;
}
RTCVideoEncoder::~RTCVideoEncoder() {
@@ -732,17 +753,9 @@
Release();
}
- webrtc::VideoCodecType video_codec_type;
- if (profile_ >= media::VP8PROFILE_MIN && profile_ <= media::VP8PROFILE_MAX) {
- video_codec_type = webrtc::kVideoCodecVP8;
- } else if (profile_ >= media::H264PROFILE_MIN &&
- profile_ <= media::H264PROFILE_MAX) {
- video_codec_type = webrtc::kVideoCodecH264;
- } else {
- NOTREACHED() << "Invalid video codec type";
- return WEBRTC_VIDEO_CODEC_ERR_PARAMETER;
- }
- impl_ = new Impl(gpu_factories_, video_codec_type);
+ impl_ = new Impl(gpu_factories_, video_codec_type_);
+ const media::VideoCodecProfile profile = WebRTCVideoCodecToVideoCodecProfile(
+ impl_->video_codec_type(), codec_settings);
base::WaitableEvent initialization_waiter(
base::WaitableEvent::ResetPolicy::MANUAL,
@@ -754,13 +767,13 @@
impl_,
gfx::Size(codec_settings->width, codec_settings->height),
codec_settings->startBitrate,
- profile_,
+ profile,
&initialization_waiter,
&initialization_retval));
// webrtc::VideoEncoder expects this call to be synchronous.
initialization_waiter.Wait();
- RecordInitEncodeUMA(initialization_retval, profile_);
+ RecordInitEncodeUMA(initialization_retval, profile);
return initialization_retval;
}
« no previous file with comments | « content/renderer/media/gpu/rtc_video_encoder.h ('k') | content/renderer/media/gpu/rtc_video_encoder_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698