Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2521903004: Use a scoped_refptr in the IndexedDBCallbacks constructor. (Closed)

Created:
4 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
4 years ago
Reviewers:
cmumford
CC:
chromium-reviews, cmumford, darin-cc_chromium.org, jam, jsbell+idb_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a scoped_refptr in the IndexedDBCallbacks constructor. Follow-up to r433964 to change IndexedDBCallbacks to take its IndexedDBDispatcherHost argument as a scoped_refptr as suggested by dcheng@. BUG=None Committed: https://crrev.com/25f132ffa3cd92cc25dcc35ea556dabcb6d0895e Cr-Commit-Position: refs/heads/master@{#434822}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/indexed_db/indexed_db_callbacks.h View 1 chunk +1 line, -1 line 3 comments Download
M content/browser/indexed_db/indexed_db_callbacks.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 1 month ago (2016-11-22 21:01:27 UTC) #3
cmumford
https://codereview.chromium.org/2521903004/diff/1/content/browser/indexed_db/indexed_db_callbacks.h File content/browser/indexed_db/indexed_db_callbacks.h (right): https://codereview.chromium.org/2521903004/diff/1/content/browser/indexed_db/indexed_db_callbacks.h#newcode40 content/browser/indexed_db/indexed_db_callbacks.h:40: scoped_refptr<IndexedDBDispatcherHost> dispatcher_host, This change looks good, but can you ...
4 years, 1 month ago (2016-11-22 21:40:10 UTC) #5
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2521903004/diff/1/content/browser/indexed_db/indexed_db_callbacks.h File content/browser/indexed_db/indexed_db_callbacks.h (right): https://codereview.chromium.org/2521903004/diff/1/content/browser/indexed_db/indexed_db_callbacks.h#newcode40 content/browser/indexed_db/indexed_db_callbacks.h:40: scoped_refptr<IndexedDBDispatcherHost> dispatcher_host, On 2016/11/22 at 21:40:10, cmumford wrote: > ...
4 years, 1 month ago (2016-11-22 21:54:53 UTC) #6
cmumford
lgtm https://codereview.chromium.org/2521903004/diff/1/content/browser/indexed_db/indexed_db_callbacks.h File content/browser/indexed_db/indexed_db_callbacks.h (right): https://codereview.chromium.org/2521903004/diff/1/content/browser/indexed_db/indexed_db_callbacks.h#newcode40 content/browser/indexed_db/indexed_db_callbacks.h:40: scoped_refptr<IndexedDBDispatcherHost> dispatcher_host, On 2016/11/22 21:54:53, Reilly Grant wrote: ...
4 years ago (2016-11-28 21:57:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521903004/1
4 years ago (2016-11-28 22:56:31 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 01:48:55 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-29 01:50:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25f132ffa3cd92cc25dcc35ea556dabcb6d0895e
Cr-Commit-Position: refs/heads/master@{#434822}

Powered by Google App Engine
This is Rietveld 408576698