Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: content/browser/indexed_db/indexed_db_callbacks.h

Issue 2521903004: Use a scoped_refptr in the IndexedDBCallbacks constructor. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/indexed_db/indexed_db_callbacks.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CALLBACKS_H_ 5 #ifndef CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CALLBACKS_H_
6 #define CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CALLBACKS_H_ 6 #define CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CALLBACKS_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 19 matching lines...) Expand all
30 class IndexedDBDatabase; 30 class IndexedDBDatabase;
31 struct IndexedDBDataLossInfo; 31 struct IndexedDBDataLossInfo;
32 struct IndexedDBDatabaseMetadata; 32 struct IndexedDBDatabaseMetadata;
33 struct IndexedDBReturnValue; 33 struct IndexedDBReturnValue;
34 struct IndexedDBValue; 34 struct IndexedDBValue;
35 35
36 class CONTENT_EXPORT IndexedDBCallbacks 36 class CONTENT_EXPORT IndexedDBCallbacks
37 : public base::RefCounted<IndexedDBCallbacks> { 37 : public base::RefCounted<IndexedDBCallbacks> {
38 public: 38 public:
39 IndexedDBCallbacks( 39 IndexedDBCallbacks(
40 IndexedDBDispatcherHost* dispatcher_host, 40 scoped_refptr<IndexedDBDispatcherHost> dispatcher_host,
cmumford 2016/11/22 21:40:10 This change looks good, but can you also change th
Reilly Grant (use Gerrit) 2016/11/22 21:54:53 What other constructors? After landing my last Moj
cmumford 2016/11/28 21:57:28 Nevermind. resolved in offline discussion.
41 const url::Origin& origin, 41 const url::Origin& origin,
42 ::indexed_db::mojom::CallbacksAssociatedPtrInfo callbacks_info); 42 ::indexed_db::mojom::CallbacksAssociatedPtrInfo callbacks_info);
43 43
44 virtual void OnError(const IndexedDBDatabaseError& error); 44 virtual void OnError(const IndexedDBDatabaseError& error);
45 45
46 // IndexedDBFactory::GetDatabaseNames 46 // IndexedDBFactory::GetDatabaseNames
47 virtual void OnSuccess(const std::vector<base::string16>& string); 47 virtual void OnSuccess(const std::vector<base::string16>& string);
48 48
49 // IndexedDBFactory::Open / DeleteDatabase 49 // IndexedDBFactory::Open / DeleteDatabase
50 virtual void OnBlocked(int64_t existing_version); 50 virtual void OnBlocked(int64_t existing_version);
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 131
132 std::unique_ptr<IOThreadHelper, BrowserThread::DeleteOnIOThread> io_helper_; 132 std::unique_ptr<IOThreadHelper, BrowserThread::DeleteOnIOThread> io_helper_;
133 base::ThreadChecker thread_checker_; 133 base::ThreadChecker thread_checker_;
134 134
135 DISALLOW_COPY_AND_ASSIGN(IndexedDBCallbacks); 135 DISALLOW_COPY_AND_ASSIGN(IndexedDBCallbacks);
136 }; 136 };
137 137
138 } // namespace content 138 } // namespace content
139 139
140 #endif // CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CALLBACKS_H_ 140 #endif // CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CALLBACKS_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/indexed_db/indexed_db_callbacks.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698