content/browser/indexed_db/indexed_db_callbacks.h - Issue 2521903004: Use a scoped_refptr in the IndexedDBCallbacks constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_callbacks.h

Issue 2521903004: Use a scoped_refptr in the IndexedDBCallbacks constructor. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/indexed_db/indexed_db_callbacks.h

diff --git a/content/browser/indexed_db/indexed_db_callbacks.h b/content/browser/indexed_db/indexed_db_callbacks.h

index 6bf0c9d4489b31e7d2d9898f817e4e9511205f93..bf26a1d436bd4eb4e24d13230298046339bd3de6 100644

--- a/content/browser/indexed_db/indexed_db_callbacks.h

+++ b/content/browser/indexed_db/indexed_db_callbacks.h

@@ -37,7 +37,7 @@ class CONTENT_EXPORT IndexedDBCallbacks

: public base::RefCounted<IndexedDBCallbacks> {

public:

IndexedDBCallbacks(

- IndexedDBDispatcherHost* dispatcher_host,

+ scoped_refptr<IndexedDBDispatcherHost> dispatcher_host,

cmumford 2016/11/22 21:40:10 This change looks good, but can you also change th

Reilly Grant (use Gerrit) 2016/11/22 21:54:53 What other constructors? After landing my last Moj

cmumford 2016/11/28 21:57:28 Nevermind. resolved in offline discussion.

const url::Origin& origin,

::indexed_db::mojom::CallbacksAssociatedPtrInfo callbacks_info);

« no previous file with comments | « no previous file | content/browser/indexed_db/indexed_db_callbacks.cc » ('j') | no next file with comments »