webkit: Catch OSError for when gperf isn't avaliable.

webkit: Catch OSError for when gperf isn't avaliable.

Previously the error output would look like this;
----
[48/17064] ACTION //third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: gen/blink/core/CSSPropertyNames.cpp gen/blink/core/CSSPropertyNames.h
python ../../third_party/WebKit/Source/build/scripts/make_css_property_names.py ../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir gen/blink/core --gperf gperf
Traceback (most recent call last):
  File "../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line 238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File "/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py", line 108, in main
    writer.write_files(options.output_dir)
  File "/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py", line 60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File "../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line 233, in generate_implementation
    gperf = subprocess.Popen(gperf_args, stdin=subprocess.PIPE, stdout=subprocess.PIPE, universal_newlines=True)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
[79/17064] CXX obj/third_party/angle/libANGLE/Caps.o
----
ninja: Entering directory `out/Release'
[2/3] ACTION //third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: python ../../third_party/WebKit/Source/build/scripts/make_css_property_names.py ../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir gen/blink/core --gperf gperf
--key-positions=*: gperf: command not found
Traceback (most recent call last):
  File "../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line 238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File "/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line 108, in main
    writer.write_files(options.output_dir)
  File "/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line 60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File "../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line 234, in generate_implementation
    return subprocess.check_output(gperf_args, universal_newlines=True, shell=True)
  File "/usr/lib/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['gperf', '--key-positions=*', '-P', '-n', '-m', '50', '-D']' returned non-zero exit status 127
----

BUG=666161
Review-Url: https://codereview.chromium.org/2521893002
Cr-Commit-Position: refs/heads/master@{#447256}
Committed: https://chromium.googlesource.com/chromium/src/+/7eb63c7a0993f13b444e4a2fda274d0d7df9a576

[mithro, 2016-11-22 03:49:55]

The CQ bit was checked by tansell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 03:50:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mithro, 2016-11-22 03:54:27]

tansell@chromium.org changed reviewers:
+ timloh@chromium.org

[commit-bot: I haz the power, 2016-11-22 05:07:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 05:07:55]

Dry run: This issue passed the CQ dry run.

[mithro, 2016-11-30 04:05:39]

Poke?

[mithro, 2016-11-30 06:31:16]

The CQ bit was checked by tansell@chromium.org

[commit-bot: I haz the power, 2016-11-30 06:32:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 06:32:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 06:32:07]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Timothy Loh, 2016-12-01 03:01:03]

On 2016/11/30 04:05:39, mithro wrote:
> Poke?

scottmg@ closed the bug as WontFix.

[Timothy Loh, 2016-12-05 03:50:03]

I'm not sure this error message helps. Isn't the user likely to just manually
install gperf at this point and then encounter more failing steps later? If our
build instructions aren't clear then we should try to improve them, otherwise
there are bound to be plenty of other steps which will fail and be similarly
unhelpful.

[djd-OOO-Apr2017, 2016-12-07 04:37:11]

On 2016/12/05 03:50:03, Timothy Loh wrote:
> I'm not sure this error message helps. Isn't the user likely to just manually
> install gperf at this point and then encounter more failing steps later? If
our
> build instructions aren't clear then we should try to improve them, otherwise
> there are bound to be plenty of other steps which will fail and be similarly
> unhelpful.

My 2 cents: this change would have been massively helpful in getting this
command to run for me.

At the moment it just emits "No such file or directory" which made me think one
of the referenced files on the command line was missing. I would never have
guessed that gperf was what was missing .From an outsider's perspective, it's
not clear that "--gperf gperf" is even referencing a binary, as opposed to some
other configuration. At least knowing that gperf was missing would have made
searching for the fix simpler. IMO, you should never have to walk through a
stack trace to diagnose this type of error.

[mithro, 2017-01-30 20:09:32]

Description was changed from

==========
webkit: Catch OSError for when gperf isn't avaliable.

Previously the error output would look like this;
----
[48/17064] ACTION
//third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: gen/blink/core/CSSPropertyNames.cpp gen/blink/core/CSSPropertyNames.h
python ../../third_party/WebKit/Source/build/scripts/make_css_property_names.py
../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir
gen/blink/core --gperf gperf
Traceback (most recent call last):
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File
"/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py",
line 108, in main
    writer.write_files(options.output_dir)
  File
"/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py",
line 60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
233, in generate_implementation
    gperf = subprocess.Popen(gperf_args, stdin=subprocess.PIPE,
stdout=subprocess.PIPE, universal_newlines=True)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
[79/17064] CXX obj/third_party/angle/libANGLE/Caps.o
----
ninja: Entering directory `out/Release'
[2/3] ACTION
//third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: python
../../third_party/WebKit/Source/build/scripts/make_css_property_names.py
../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir
gen/blink/core --gperf gperf
--key-positions=*: gperf: command not found
Traceback (most recent call last):
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File
"/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line
108, in main
    writer.write_files(options.output_dir)
  File
"/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line
60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
234, in generate_implementation
    return subprocess.check_output(gperf_args, universal_newlines=True,
shell=True)
  File "/usr/lib/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['gperf', '--key-positions=*', '-P',
'-n', '-m', '50', '-D']' returned non-zero exit status 127
----

BUG=666161
==========

to

==========
webkit: Catch OSError for when gperf isn't avaliable.

Previously the error output would look like this;
----
[48/17064] ACTION
//third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: gen/blink/core/CSSPropertyNames.cpp gen/blink/core/CSSPropertyNames.h
python ../../third_party/WebKit/Source/build/scripts/make_css_property_names.py
../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir
gen/blink/core --gperf gperf
Traceback (most recent call last):
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File
"/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py",
line 108, in main
    writer.write_files(options.output_dir)
  File
"/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py",
line 60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
233, in generate_implementation
    gperf = subprocess.Popen(gperf_args, stdin=subprocess.PIPE,
stdout=subprocess.PIPE, universal_newlines=True)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
[79/17064] CXX obj/third_party/angle/libANGLE/Caps.o
----
ninja: Entering directory `out/Release'
[2/3] ACTION
//third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: python
../../third_party/WebKit/Source/build/scripts/make_css_property_names.py
../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir
gen/blink/core --gperf gperf
--key-positions=*: gperf: command not found
Traceback (most recent call last):
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File
"/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line
108, in main
    writer.write_files(options.output_dir)
  File
"/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line
60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
234, in generate_implementation
    return subprocess.check_output(gperf_args, universal_newlines=True,
shell=True)
  File "/usr/lib/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['gperf', '--key-positions=*', '-P',
'-n', '-m', '50', '-D']' returned non-zero exit status 127
----

BUG=666161
==========

[mithro, 2017-01-30 20:09:32]

tansell@chromium.org changed reviewers:
+ meade@chromium.org
- timloh@chromium.org

[mithro, 2017-01-30 20:10:30]

Hi Eddy,

Since Tim is no longer on style team, could you look at this CL?

Thanks!

Tim 'mithro' Ansell

[meade_UTC10, 2017-01-31 00:12:08]

lgtm

[mithro, 2017-01-31 01:31:57]

The CQ bit was checked by tansell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 01:32:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 03:14:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 03:14:23]

Dry run: This issue passed the CQ dry run.

[mithro, 2017-01-31 17:23:37]

The CQ bit was checked by tansell@chromium.org

[commit-bot: I haz the power, 2017-01-31 17:24:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 17:28:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485883417239830,
"parent_rev": "fbec70803634ad206932f90e7b97dd533f4b9cfd", "commit_rev":
"7eb63c7a0993f13b444e4a2fda274d0d7df9a576"}

[commit-bot: I haz the power, 2017-01-31 17:29:14]

Description was changed from

==========
webkit: Catch OSError for when gperf isn't avaliable.

Previously the error output would look like this;
----
[48/17064] ACTION
//third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: gen/blink/core/CSSPropertyNames.cpp gen/blink/core/CSSPropertyNames.h
python ../../third_party/WebKit/Source/build/scripts/make_css_property_names.py
../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir
gen/blink/core --gperf gperf
Traceback (most recent call last):
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File
"/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py",
line 108, in main
    writer.write_files(options.output_dir)
  File
"/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py",
line 60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
233, in generate_implementation
    gperf = subprocess.Popen(gperf_args, stdin=subprocess.PIPE,
stdout=subprocess.PIPE, universal_newlines=True)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
[79/17064] CXX obj/third_party/angle/libANGLE/Caps.o
----
ninja: Entering directory `out/Release'
[2/3] ACTION
//third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: python
../../third_party/WebKit/Source/build/scripts/make_css_property_names.py
../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir
gen/blink/core --gperf gperf
--key-positions=*: gperf: command not found
Traceback (most recent call last):
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File
"/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line
108, in main
    writer.write_files(options.output_dir)
  File
"/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line
60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
234, in generate_implementation
    return subprocess.check_output(gperf_args, universal_newlines=True,
shell=True)
  File "/usr/lib/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['gperf', '--key-positions=*', '-P',
'-n', '-m', '50', '-D']' returned non-zero exit status 127
----

BUG=666161
==========

to

==========
webkit: Catch OSError for when gperf isn't avaliable.

Previously the error output would look like this;
----
[48/17064] ACTION
//third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: gen/blink/core/CSSPropertyNames.cpp gen/blink/core/CSSPropertyNames.h
python ../../third_party/WebKit/Source/build/scripts/make_css_property_names.py
../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir
gen/blink/core --gperf gperf
Traceback (most recent call last):
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File
"/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py",
line 108, in main
    writer.write_files(options.output_dir)
  File
"/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py",
line 60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
233, in generate_implementation
    gperf = subprocess.Popen(gperf_args, stdin=subprocess.PIPE,
stdout=subprocess.PIPE, universal_newlines=True)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
[79/17064] CXX obj/third_party/angle/libANGLE/Caps.o
----
ninja: Entering directory `out/Release'
[2/3] ACTION
//third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: python
../../third_party/WebKit/Source/build/scripts/make_css_property_names.py
../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir
gen/blink/core --gperf gperf
--key-positions=*: gperf: command not found
Traceback (most recent call last):
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File
"/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line
108, in main
    writer.write_files(options.output_dir)
  File
"/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line
60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
234, in generate_implementation
    return subprocess.check_output(gperf_args, universal_newlines=True,
shell=True)
  File "/usr/lib/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['gperf', '--key-positions=*', '-P',
'-n', '-m', '50', '-D']' returned non-zero exit status 127
----

BUG=666161

Review-Url: https://codereview.chromium.org/2521893002
Cr-Commit-Position: refs/heads/master@{#447256}
Committed:
https://chromium.googlesource.com/chromium/src/+/7eb63c7a0993f13b444e4a2fda27...
==========

[commit-bot: I haz the power, 2017-01-31 17:29:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7eb63c7a0993f13b444e4a2fda27...