Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2517383003: webkit: Use subprocess.check_output

Created:
4 years, 1 month ago by mithro
Modified:
3 years, 10 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webkit: Use subprocess.check_output Fixes "FIXME" and makes this file Python 2.7 only. BUG=666161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/build/scripts/make_css_property_names.py View 2 chunks +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (12 generated)
mithro
Is there anyone still using anything earlier than Python 2.7!?
4 years, 1 month ago (2016-11-22 03:55:34 UTC) #2
Timothy Loh
lgtm but update make_css_value_keywords.py too where this is copy-pasted On 2016/11/22 03:55:34, mithro wrote: > ...
4 years, 1 month ago (2016-11-23 00:29:43 UTC) #3
commit-bot: I haz the power
4 years ago (2016-11-30 06:34:20 UTC) #7
This CL has an open dependency (Issue 2521893002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

Powered by Google App Engine
This is Rietveld 408576698