Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 2521483002: Remove ResourceLoaderInfo::encodedDataLength (Closed)

Created:
4 years, 1 month ago by yhirano
Modified:
4 years ago
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, blink-reviews-api_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ResourceLoaderInfo::encodedDataLength It is redundant as we have the field in ResourceResponse. BUG=666217 Committed: https://crrev.com/ab7cdd7f214d3a625ab737dc17b977c89021d786 Cr-Commit-Position: refs/heads/master@{#434875}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -24 lines) Patch
M content/child/web_url_loader_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebHTTPLoadInfo.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceLoadInfo.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebHTTPLoadInfo.h View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 32 (15 generated)
yhirano
4 years, 1 month ago (2016-11-21 05:52:35 UTC) #4
hiroshige
On 2016/11/21 05:52:35, yhirano wrote: Have you checked that these two values are always the ...
4 years, 1 month ago (2016-11-21 05:59:08 UTC) #5
yhirano
On 2016/11/21 05:59:08, hiroshige wrote: > On 2016/11/21 05:52:35, yhirano wrote: > > Have you ...
4 years, 1 month ago (2016-11-21 06:06:14 UTC) #6
hiroshige
lgtm
4 years, 1 month ago (2016-11-21 06:13:48 UTC) #7
yhirano
Correction: I've just noticed we don't update the field on each data chunk, so two ...
4 years, 1 month ago (2016-11-21 06:57:08 UTC) #8
yhirano
On 2016/11/21 06:57:08, yhirano wrote: > Correction: I've just noticed we don't update the field ...
4 years, 1 month ago (2016-11-21 06:59:50 UTC) #9
allada
lgtm
4 years, 1 month ago (2016-11-21 19:43:18 UTC) #16
yhirano
+pfeldman@ for OWNER review.
4 years, 1 month ago (2016-11-22 03:49:30 UTC) #18
allada
+dgozman is more familiar with this area.
4 years, 1 month ago (2016-11-22 04:11:08 UTC) #20
yhirano
On 2016/11/22 04:11:08, Blaise wrote: > +dgozman is more familiar with this area. (Still I ...
4 years, 1 month ago (2016-11-22 05:13:57 UTC) #21
dgozman
lgtm Looks like ResourceResponse::encodedDataLength was introduced just recently in https://codereview.chromium.org/2316573002/.
4 years, 1 month ago (2016-11-22 17:29:57 UTC) #22
yhirano
pfeldman@: ping
4 years ago (2016-11-28 07:07:26 UTC) #23
pfeldman
lgtm
4 years ago (2016-11-28 19:02:26 UTC) #24
yhirano
Thanks!
4 years ago (2016-11-29 00:59:56 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521483002/20001
4 years ago (2016-11-29 01:01:30 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 03:50:49 UTC) #30
commit-bot: I haz the power
4 years ago (2016-11-29 03:54:25 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab7cdd7f214d3a625ab737dc17b977c89021d786
Cr-Commit-Position: refs/heads/master@{#434875}

Powered by Google App Engine
This is Rietveld 408576698